2.6.9-rc3-mm[12]: x86-64-clustered-apic-support.patch problem

2.6.9-rc3-mm[12]: x86-64-clustered-apic-support.patch problem

[Rafael J. Wysocki]

Andrew,

The patch x86-64-clustered-apic-support.patch causes the 2.6.9-rc3-mm[12] 
kernel to crash at startup on a single-CPU AMD64 box :

Bootdata ok (command line is root=/dev/hdc6 vga=792 resume=/dev/hdc3 
pci=routeirq nmi_watchdog=0 console=ttyS0,57600)
Linux version 2.6.9-rc3-mm2 (rafael@albercik) (gcc version 3.3.3 (SuSE Linux)) 
#3 Mon Oct 4 20:48:34 CEST 2004
BIOS-provided physical RAM map:
 BIOS-e820: 0000000000000000 - 000000000009fc00 (usable)
 BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved)
 BIOS-e820: 00000000000e0000 - 0000000000100000 (reserved)
 BIOS-e820: 0000000000100000 - 000000001ff40000 (usable)
 BIOS-e820: 000000001ff40000 - 000000001ff50000 (ACPI data)
 BIOS-e820: 000000001ff50000 - 0000000020000000 (ACPI NVS)
 BIOS-e820: 00000000fec00000 - 00000000fec01000 (reserved)
 BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
No mptable found.
PCI bridge 00:0a from 10de found. Setting "noapic". Overwrite with "apic"
  >>> ERROR: Invalid checksum
Intel MultiProcessor Specification v1.1
    Virtual Wire compatibility mode.
OEM ID: ASUSTeK  <6>Product ID: L5D          <6>APIC at: 0xFEE00000
Processor #0 15:4 APIC version 16
I/O APIC #1 Version 17 at 0xFEC00000.
Processors: 1
Checking aperture...
CPU 0: aperture @ e8000000 size 128 MB
Built 1 zonelists
Initializing CPU#0
Kernel command line: root=/dev/hdc6 vga=792 resume=/dev/hdc3 pci=routeirq 
nmi_watchdog=0 console=ttyS0,57600
PID hash table entries: 2048 (order: 11, 65536 bytes)
time.c: Using 1.193182 MHz PIT timer.
time.c: Detected 1795.388 MHz processor.
Console: colour dummy device 80x25
Dentry cache hash table entries: 131072 (order: 8, 1048576 bytes)
Inode-cache hash table entries: 65536 (order: 7, 524288 bytes)
Memory: 509288k/523520k available (2916k kernel code, 13684k reserved, 1152k 
data, 164k init)
Security Scaffold v1.0.0 initialized
SELinux:  Initializing.
SELinux:  Starting in permissive mode
There is already a security framework initialized, register_security failed.
selinux_register_security:  Registering secondary module capability
Capability LSM initialized as secondary
Mount-cache hash table entries: 256 (order: 0, 4096 bytes)
CPU: L1 I Cache: 64K (64 bytes/line), D cache 64K (64 bytes/line)
CPU: L2 Cache: 1024K (64 bytes/line)
CPU: AMD Athlon(tm) 64 Processor 3000+ stepping 0a
ACPI: IRQ9 SCI: Edge set to Level Trigger.
Unable to handle kernel NULL pointer dereference at 0000000000000018 RIP:
<ffffffff80597e17>{setup_local_APIC+23}
PML4 0
Oops: 0000 [1] PREEMPT
CPU 0
Modules linked in:
Pid: 1, comm: swapper Tainted: G   M  2.6.9-rc3-mm2
RIP: 0010:[<ffffffff80597e17>] <ffffffff80597e17>{setup_local_APIC+23}
RSP: 0000:000001001fe13ef8  EFLAGS: 00010212
RAX: 0000000000000000 RBX: 0000000000040010 RCX: ffffffff805093e0
RDX: 0000000000000000 RSI: 0000000001000000 RDI: ffffffff803f2baf
RBP: 0000000000000010 R08: 000000000063999d R09: 0000000000000005
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffffffff80583140(0000) knlGS:0000000000000000
CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
CR2: 0000000000000018 CR3: 0000000000101000 CR4: 00000000000006e0
Process swapper (pid: 1, threadinfo 000001001fe12000, task 000001001fe111b0)
Stack: 0000000000000000 0000000000000000 0000000000000000 ffffffff8059801b
       0000000000000001 0000000000000000 0000000000000800 ffffffff8010c0e5
       ffffffff804489a0 0000000000000800
Call Trace:<ffffffff8059801b>{APIC_init_uniprocessor+139} 
<ffffffff8010c0e5>{init+37}
       <ffffffff80111a23>{child_rip+8} <ffffffff8010c0c0>{init+0}
       <ffffffff80111a1b>{child_rip+0}

Code: ff 50 18 85 c0 75 0c 0f 0b ef 2c 3f 80 ff ff ff ff 4f 01 48
RIP <ffffffff80597e17>{setup_local_APIC+23} RSP <000001001fe13ef8>
CR2: 0000000000000018
 <0>Kernel panic - not syncing: Attempted to kill init!

At the same time, on a dual-Opteron box w/ NUMA the kernel starts just fine.

The one-processor .config for 2.6.9-rc3-mm2 is available at:
http://www.sisk.pl/kernel/041004/2.6.9-rc3-mm2-1CPU.config
The corresponding dual-CPU .config is available at:
http://www.sisk.pl/kernel/041004/2.6.9-rc3-mm2-NUMA.config

Greets,
RJW

-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"

Re: 2.6.9-rc3-mm[12]: x86-64-clustered-apic-support.patch problem

[Andi Kleen]

"Rafael J. Wysocki" <rjw@sisk.pl> writes:

> Andrew,
>
> The patch x86-64-clustered-apic-support.patch causes the 2.6.9-rc3-mm[12] 
> kernel to crash at startup on a single-CPU AMD64 box :

This untested patch may fix it. Does it?

-Andi

Index: linux/arch/x86_64/kernel/genapic.c
===================================================================
--- linux.orig/arch/x86_64/kernel/genapic.c	2004-10-03 16:28:07.%N +0200
+++ linux/arch/x86_64/kernel/genapic.c	2004-10-03 17:05:10.%N +0200
@@ -27,7 +27,7 @@
 extern struct genapic apic_cluster;
 extern struct genapic apic_flat;
 
-struct genapic *genapic;
+struct genapic *genapic = &apic_flat;
 
 
 /*

Re: 2.6.9-rc3-mm[12]: x86-64-clustered-apic-support.patch problem

[Rafael J. Wysocki]

On Monday 04 of October 2004 22:40, Andi Kleen wrote:
> "Rafael J. Wysocki" <rjw@sisk.pl> writes:
> 
> > Andrew,
> >
> > The patch x86-64-clustered-apic-support.patch causes the 2.6.9-rc3-mm[12] 
> > kernel to crash at startup on a single-CPU AMD64 box :
> 
> This untested patch may fix it. Does it?
> 
> -Andi
> 
> Index: linux/arch/x86_64/kernel/genapic.c
> ===================================================================
> --- linux.orig/arch/x86_64/kernel/genapic.c	2004-10-03 16:28:07.%N +0200
> +++ linux/arch/x86_64/kernel/genapic.c	2004-10-03 17:05:10.%N +0200
> @@ -27,7 +27,7 @@
>  extern struct genapic apic_cluster;
>  extern struct genapic apic_flat;
>  
> -struct genapic *genapic;
> +struct genapic *genapic = &apic_flat;
>  
>  
>  /*

Yes, it does.

Greets,
RJW

-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"