Re: [PATCH] s390 (9/9): no timer interrupts in idle.

[Andi Kleen <ak@muc.de>]

Dipankar Sarma <dipankar@in.ibm.com> writes:

> On Wed, Apr 21, 2004 at 09:46:05PM +0100, Christoph Hellwig wrote:
>> On Thu, Apr 22, 2004 at 02:13:04AM +0530, Dipankar Sarma wrote:
>> > I think CPU_MASK_NONE can be used only for assignments. You need
>> > to actually declare a generic idle_cpu_mask and set it to CPU_MASK_NONE
>> > for all other archs. Of course, then the compiler will not be able
>> > to optimize it out :)
>> 
>> Well, there's a const keyword in C these days, no?

It is not strong enough in C unfortunately. It is still legal 
to change const variables, so the compiler has to take that into
account and it is hard for global variables. C++ is better here.

> OK, then I missed what optimization you were talking about or underestimated
> gcc. Can gcc do inter-procedural constant propagation ?

Only when the functions are inlined
(but it is much better at that than it used to be, gcc 3.4 can even
inline across multiple files and order doesn't matter anymore) 

-Andi