From: Krzysztof Halasa <khc@pm.waw.pl>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Joe Perches <joe@perches.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Borislav Petkov <petkovbb@gmail.com>
Subject: Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice(
Date: Mon, 18 May 2009 15:22:01 +0200 [thread overview]
Message-ID: <m3skj2im12.fsf@intrepid.localdomain> (raw)
In-Reply-To: <4A11343C.5070809@ru.mvista.com> (Sergei Shtylyov's message of "Mon\, 18 May 2009 14\:11\:08 +0400")
Sergei Shtylyov <sshtylyov@ru.mvista.com> writes:
>> } else {
>> floppy->blocks = blocks;
>> floppy->block_size = length;
>> floppy->bs_factor = length / 512;
>> if (floppy->bs_factor != 1)
>> - printk(KERN_NOTICE PFX "%s: Warning: "
>> - "non 512 bytes block size not "
>> - "fully supported\n",
>> - drive->name);
>> + pr_notice(PFX "%s: Warning: non 512 bytes block size not fully supported\n",
>>
>
> Again.
(> 80 chars in line)
Though I think most people would agree that the latter is much better,
no?
I think removal (rewording) of this rule has already been agreed upon,
though not exactly yet codified.
--
Krzysztof Halasa
next prev parent reply other threads:[~2009-05-18 13:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 2:21 [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>( Joe Perches
2009-05-18 2:21 ` [PATCH 1/6] drivers/ide: Convert printk(KERN_DEBUG to pr_debug( Joe Perches
2009-05-18 9:34 ` Sergei Shtylyov
2009-05-18 2:21 ` [PATCH 2/6] drivers/ide: Convert printk(KERN_INFO to pr_info( Joe Perches
2009-05-18 2:31 ` Joe Perches
2009-05-18 2:21 ` [PATCH 3/6] drivers/ide: Convert printk(KERN_ERR to pr_err( Joe Perches
2009-05-18 2:21 ` [PATCH 4/6] drivers/ide: Convert printk(KERN_WARNING to pr_warning( Joe Perches
2009-05-18 2:21 ` [PATCH 5/6] drivers/ide: Convert printk(KERN_CONT to pr_cont( Joe Perches
2009-05-18 2:21 ` [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice( Joe Perches
2009-05-18 10:11 ` Sergei Shtylyov
2009-05-18 13:22 ` Krzysztof Halasa [this message]
2009-05-18 13:38 ` Sergei Shtylyov
2009-05-18 13:50 ` Bartlomiej Zolnierkiewicz
2009-05-18 17:18 ` Krzysztof Halasa
2009-05-18 18:55 ` Alan Cox
2009-05-18 13:32 ` Joe Perches
2009-05-18 14:12 ` [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>( Bartlomiej Zolnierkiewicz
2009-05-18 15:41 ` Joe Perches
2009-05-18 15:48 ` Bartlomiej Zolnierkiewicz
2009-05-18 15:56 ` James Bottomley
2009-05-18 20:59 ` Joe Perches
2009-05-18 21:15 ` James Bottomley
2009-05-18 21:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3skj2im12.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=bzolnier@gmail.com \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox