From: Peter Osterlund <petero2@telia.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: local_irq_enable() in __do_softirq()?
Date: 30 Jul 2005 12:32:30 +0200 [thread overview]
Message-ID: <m3slxwmvnl.fsf@telia.com> (raw)
Hi,
The change "x86_64: Switch to the interrupt stack when running a
softirq in local_bh ..." (ed6b676ca8b50e0b538e61c283d52fd04f007abf)
contains this:
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -86,7 +86,7 @@ restart:
/* Reset the pending bitmask before enabling irqs */
local_softirq_pending() = 0;
- local_irq_enable();
+ //local_irq_enable();
h = softirq_vec;
@@ -99,7 +99,7 @@ restart:
pending >>= 1;
} while (pending);
- local_irq_disable();
+ //local_irq_disable();
pending = local_softirq_pending();
if (pending && --max_restart)
Is that intentional? If so, shouldn't the code be removed instead of
commented out?
--
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340
reply other threads:[~2005-07-30 10:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3slxwmvnl.fsf@telia.com \
--to=petero2@telia.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox