From: Andi Kleen <ak@muc.de>
To: "Tomar, Nagendra" <nagendra_tomar@adaptec.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: why change_page_attr on x86 uses __flush_tlb_all
Date: Thu, 15 Apr 2004 15:51:07 +0200 [thread overview]
Message-ID: <m3smf5ic38.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1Lek1-5lB-3@gated-at.bofh.it> (Nagendra Singh Tomar's message of "Thu, 15 Apr 2004 14:40:09 +0200")
Nagendra Singh Tomar <nagendra_tomar@adaptec.com> writes:
> I would expect __flush_tlb_one (for each page) as a better choice.
> It'll be nice if someone can hoghlight on why __flush_tlb_all is used.
> The kernel version I am referring from is 2.4.18-14
This works around a bug in some early Athlons with flushing global
large pages. Also it makes the code slightly simpler and change_page_attr
is not really performance critical.
-Andi
next parent reply other threads:[~2004-04-15 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1Lek1-5lB-3@gated-at.bofh.it>
2004-04-15 13:51 ` Andi Kleen [this message]
2004-04-20 13:03 ` why change_page_attr on x86 uses __flush_tlb_all Pavel Machek
2004-04-15 12:32 Nagendra Singh Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3smf5ic38.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nagendra_tomar@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox