* why change_page_attr on x86 uses __flush_tlb_all
@ 2004-04-15 12:32 Nagendra Singh Tomar
0 siblings, 0 replies; 3+ messages in thread
From: Nagendra Singh Tomar @ 2004-04-15 12:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Tomar, Nagendra
Hi,
I would expect __flush_tlb_one (for each page) as a better choice.
It'll be nice if someone can hoghlight on why __flush_tlb_all is used.
The kernel version I am referring from is 2.4.18-14
Thanx,
tomar
PS: Please CC to my email-id as I'm not able to access the list.
-- You have moved the mouse. Windows must be restarted for the
changes to take effect.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: why change_page_attr on x86 uses __flush_tlb_all
[not found] <1Lek1-5lB-3@gated-at.bofh.it>
@ 2004-04-15 13:51 ` Andi Kleen
2004-04-20 13:03 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2004-04-15 13:51 UTC (permalink / raw)
To: Tomar, Nagendra; +Cc: linux-kernel
Nagendra Singh Tomar <nagendra_tomar@adaptec.com> writes:
> I would expect __flush_tlb_one (for each page) as a better choice.
> It'll be nice if someone can hoghlight on why __flush_tlb_all is used.
> The kernel version I am referring from is 2.4.18-14
This works around a bug in some early Athlons with flushing global
large pages. Also it makes the code slightly simpler and change_page_attr
is not really performance critical.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: why change_page_attr on x86 uses __flush_tlb_all
2004-04-15 13:51 ` why change_page_attr on x86 uses __flush_tlb_all Andi Kleen
@ 2004-04-20 13:03 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2004-04-20 13:03 UTC (permalink / raw)
To: Andi Kleen; +Cc: Tomar, Nagendra, linux-kernel
Hi!
> > I would expect __flush_tlb_one (for each page) as a better choice.
> > It'll be nice if someone can hoghlight on why __flush_tlb_all is used.
> > The kernel version I am referring from is 2.4.18-14
>
> This works around a bug in some early Athlons with flushing global
> large pages. Also it makes the code slightly simpler and change_page_attr
> is not really performance critical.
Perhaps comment should be added? Otherwise someone is going
to "fix" it sooner or later.
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-04-22 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1Lek1-5lB-3@gated-at.bofh.it>
2004-04-15 13:51 ` why change_page_attr on x86 uses __flush_tlb_all Andi Kleen
2004-04-20 13:03 ` Pavel Machek
2004-04-15 12:32 Nagendra Singh Tomar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox