From: khalasa@piap.pl (Krzysztof Hałasa)
To: Joe Perches <joe@perches.com>
Cc: Mario Bambagini <mario.bambagini@gmail.com>,
linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH] defines modified to match the 80-char rule
Date: Mon, 06 Jul 2015 14:16:44 +0200 [thread overview]
Message-ID: <m3twtho503.fsf@t19.piap.pl> (raw)
In-Reply-To: <1436170038.2682.7.camel@perches.com> (Joe Perches's message of "Mon, 06 Jul 2015 01:07:18 -0700")
Joe Perches <joe@perches.com> writes:
>> So, could we have the localized readability when it makes sense,
>> and the default rules when nothing else applies?
>
> Then the question becomes how local.
The answer seems easy to me: as much as it's needed to get the best
readability.
If that means 4 or 2 custom formatted lines, great. Why not?
It should be the maintainer's call anyway. It's (s)he who has to work
with the code in question most.
>> OTOH I think the 80 columns rule should go.
>
> I have no issue with that.
> There should be some limit though.
Sure, the max readability should set the limit. Though I would say one
shouldn't exceed maybe 132 chars (this is what old VT100 had, and this
is also supported on PC since some 8-bit XT-BUS VGA cards).
132 chars also allow for full 80-char "console output text" lines.
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2015-07-06 12:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 21:21 [PATCH] defines modified to match the 80-char rule Mario Bambagini
2015-07-01 7:59 ` Krzysztof Hałasa
2015-07-02 6:20 ` Joe Perches
2015-07-02 18:01 ` Joe Perches
2015-07-03 10:58 ` Krzysztof Hałasa
2015-07-03 16:10 ` Joe Perches
2015-07-06 6:07 ` Krzysztof Hałasa
2015-07-06 8:07 ` Joe Perches
2015-07-06 12:16 ` Krzysztof Hałasa [this message]
2015-07-08 15:30 ` Joe Perches
2015-07-06 8:30 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3twtho503.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.bambagini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox