From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755267AbbGFMQw (ORCPT ); Mon, 6 Jul 2015 08:16:52 -0400 Received: from ni.piap.pl ([195.187.100.4]:56165 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754383AbbGFMQs (ORCPT ); Mon, 6 Jul 2015 08:16:48 -0400 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) To: Joe Perches Cc: Mario Bambagini , linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH] defines modified to match the 80-char rule References: <1435094481-32275-1-git-send-email-mario.bambagini@gmail.com> <1435818026.2487.5.camel@perches.com> <1435860103.2487.30.camel@perches.com> <1435939832.2487.64.camel@perches.com> <1436170038.2682.7.camel@perches.com> Date: Mon, 06 Jul 2015 14:16:44 +0200 In-Reply-To: <1436170038.2682.7.camel@perches.com> (Joe Perches's message of "Mon, 06 Jul 2015 01:07:18 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 80444 [Jul 06 2015] X-KLMS-AntiSpam-Version: 5.5.6 X-KLMS-AntiSpam-Envelope-From: khalasa@piap.pl X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Moebius-Timestamps: 3637225, 3637239, 3637240 X-KLMS-AntiSpam-Info: LuaCore: 234 2015-06-28_22-28-24 b8758651e3de11965e9a6cf595acada6fc137d13, Auth:dkim=none X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, 2015/07/06 07:52:14 X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2015/07/06 08:08:00 #8191714 X-KLMS-AntiVirus-Status: Clean, skipped Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches writes: >> So, could we have the localized readability when it makes sense, >> and the default rules when nothing else applies? > > Then the question becomes how local. The answer seems easy to me: as much as it's needed to get the best readability. If that means 4 or 2 custom formatted lines, great. Why not? It should be the maintainer's call anyway. It's (s)he who has to work with the code in question most. >> OTOH I think the 80 columns rule should go. > > I have no issue with that. > There should be some limit though. Sure, the max readability should set the limit. Though I would say one shouldn't exceed maybe 132 chars (this is what old VT100 had, and this is also supported on PC since some 8-bit XT-BUS VGA cards). 132 chars also allow for full 80-char "console output text" lines. -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland