From: Chris Ball <cjb@laptop.org>
To: Kyungsik Lee <kyungsik.lee@lge.com>
Cc: Venkatraman S <svenkatr@ti.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Adrian Hunter <ext-adrian.hunter@nokia.com>,
Philip Rakity <prakity@marvell.com>,
raphael.andy.lee@gmail.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v6] mmc: core: Remove bounce buffer in mmc_send_cxd_data()
Date: Mon, 17 Sep 2012 03:32:12 -0400 [thread overview]
Message-ID: <m3txuxyuir.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <1343955483-6917-1-git-send-email-kyungsik.lee@lge.com> (Kyungsik Lee's message of "Fri, 3 Aug 2012 09:58:03 +0900")
Hi,
On Thu, Aug 02 2012, Kyungsik Lee wrote:
> It is expected that Extended CSD register(the size of this register
> is larger than CID/CSD) will be referenced more frequently as more
> fields have been added to Extended CSD and it seems that it is not
> a good option to double the memory used.
>
> This patch is intended to avoid the use of bounce buffer for reading
> Extended CSD register in mmc_send_cxd_data(). It will provide a better
> performance gain by removing memcpy() overhead for a half KiB and
> a redundant bounce buffer allocated repeatedly at the cost of providing
> DMA-capable buffer from upper caller(but on-stack buffer is allowed
> with no performance gain).
>
> Signed-off-by: Kyungsik Lee <kyungsik.lee@lge.com>
> Reviewed-by: Venkatraman S <svenkatr@ti.com>
Thanks, pushed to mmc-next for 3.7.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-09-17 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 0:58 [PATCH RESEND v6] mmc: core: Remove bounce buffer in mmc_send_cxd_data() Kyungsik Lee
2012-09-17 7:32 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3txuxyuir.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=ext-adrian.hunter@nokia.com \
--cc=jh80.chung@samsung.com \
--cc=kyungsik.lee@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
--cc=raphael.andy.lee@gmail.com \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox