From: Peter Osterlund <petero2@telia.com>
To: balagi@justmail.de
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@osdl.org" <akpm@osdl.org>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH 2/2] 2.6.19-rc1-mm1 pktcdvd: bio write congestion
Date: 14 Oct 2006 20:55:16 +0200 [thread overview]
Message-ID: <m3u026g223.fsf@telia.com> (raw)
In-Reply-To: <op.thfa4wnqiudtyh@master>
"Thomas Maier" <balagi@justmail.de> writes:
> Hello,
>
> this adds a bio write queue congestion control
> to the pktcdvd driver with fixed on/off marks.
> It prevents that the driver consumes a unlimited
> amount of write requests.
Thanks, this looks good in principle, but I think it can be
implemented in a simpler way.
Jens, can I please ask your opinion. Would it make sense to export the
clear_queue_congested() and set_queue_congested() functions in
ll_rw_blk.c so that the pktcdvd driver can use them? Something like
this patch from a few years ago:
http://marc.theaimsgroup.com/?l=linux-kernel&m=109378210610508&w=2
--
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340
next prev parent reply other threads:[~2006-10-14 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-14 18:03 [PATCH 2/2] 2.6.19-rc1-mm1 pktcdvd: bio write congestion Thomas Maier
2006-10-14 18:55 ` Peter Osterlund [this message]
2006-10-15 18:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3u026g223.fsf@telia.com \
--to=petero2@telia.com \
--cc=akpm@osdl.org \
--cc=balagi@justmail.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox