From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755576AbbJHKD1 (ORCPT ); Thu, 8 Oct 2015 06:03:27 -0400 Received: from ni.piap.pl ([195.187.100.4]:50436 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755482AbbJHKDY convert rfc822-to-8bit (ORCPT ); Thu, 8 Oct 2015 06:03:24 -0400 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow References: <2273145.0Ls8cProhs@wuerfel> <201510072201.51697.arnd@arndb.de> <12713701.B4epxIQJNF@wuerfel> Date: Thu, 08 Oct 2015 12:03:18 +0200 In-Reply-To: <12713701.B4epxIQJNF@wuerfel> (Arnd Bergmann's message of "Wed, 07 Oct 2015 22:05:49 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 84827 [Oct 08 2015] X-KLMS-AntiSpam-Version: 5.5.6 X-KLMS-AntiSpam-Envelope-From: khalasa@piap.pl X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Moebius-Timestamps: 3767412, 3767440, 3767406 X-KLMS-AntiSpam-Info: LuaCore: 291 291 f2850e2019afbe436e080871ddcea62fe024e195, Auth:dkim=none X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, 2015/10/08 07:48:05 X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2015/10/07 23:57:00 #6595058 X-KLMS-AntiVirus-Status: Clean, skipped Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Arnd Bergmann writes: > With those two changes in place, we no longer need the fake > pci_sys_data/pci_bus structures for faking config space writes, > and the stack usage goes down as well. > arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++---------------------------------------- I'm ATM unable to test this change, but will do that at some point. Meanwhile, I guess there is nothing I can say against this patch. Thanks. Acked-by: Krzysztof Hałasa -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland