From: jmoyer@redhat.com
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "'Andrew Morton'" <akpm@osdl.org>, <linux-aio@kvack.org>,
"'Trond Myklebust'" <trond.myklebust@fys.uio.no>,
"'xb'" <xavier.bru@bull.net>,
"'Zach Brown'" <zach.brown@oracle.com>,
<linux-kernel@vger.kernel.org>,
"Paul E. McKenney" <paulmck@us.ibm.com>
Subject: Re: [patch] aio: fix buggy put_ioctx call in aio_complete
Date: Thu, 21 Dec 2006 11:55:38 -0500 [thread overview]
Message-ID: <m3vek5xk6t.fsf@redhat.com> (raw)
In-Reply-To: <000101c724de$1c81d980$1b80030a@amr.corp.intel.com> (Kenneth W. Chen's message of "Thu, 21 Dec 2006 00:57:57 -0800")
==> Regarding RE: [patch] aio: fix buggy put_ioctx call in aio_complete; "Chen, Kenneth W" <kenneth.w.chen@intel.com> adds:
kenneth.w.chen> I think I'm going to abandon this whole synchronize thing
kenneth.w.chen> and going to put the wake up call inside ioctx_lock spin
kenneth.w.chen> lock along with the other patch you mentioned above in the
kenneth.w.chen> waiter path. On top of that, I have another patch attempts
kenneth.w.chen> to perform wake-up only when the waiter can truly proceed
kenneth.w.chen> in aio_read_evt so dribbling I/O completion doesn't
kenneth.w.chen> inefficiently waking up waiter too frequently and only to
kenneth.w.chen> have waiter put back to sleep again. I will dig that up and
kenneth.w.chen> experiment.
In the mean time, can't we simply take the context lock in
wait_for_all_aios? Unless I missed something, I think that will address
the reference count problem.
Thanks,
Jeff
next prev parent reply other threads:[~2006-12-21 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 21:49 [patch] aio: fix buggy put_ioctx call in aio_complete Chen, Kenneth W
2006-12-21 4:05 ` Andrew Morton
2006-12-21 7:58 ` Chen, Kenneth W
2006-12-21 8:17 ` Andrew Morton
2006-12-21 8:57 ` Chen, Kenneth W
2006-12-21 16:55 ` jmoyer [this message]
2006-12-21 17:01 ` Chen, Kenneth W
2006-12-21 17:34 ` jmoyer
2006-12-21 18:00 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vek5xk6t.fsf@redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@osdl.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=trond.myklebust@fys.uio.no \
--cc=xavier.bru@bull.net \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox