Re: serious performance regression due to NX patch

Christoph Hellwig
2004-07-11T10:22:47Z

On Sun, Jul 11, 2004 at 05:52:59AM -0400, Ingo Molnar wrote:
>
> On Sun, 11 Jul 2004, Ingo Molnar wrote:
>
> > > ok, agreed. I'll check that it still does the right thing on x86.
> >
> > it doesnt seem to do the right thing for !PT_GNU_STACK applications on
> > x86:
>
> how about the patch below? This way we recognize the fact that x86 didnt
> have any executability check previously at the point where we discover
> that it's a 'legacy' binary.

Please don't add per-architecture ifdefs to generic code. And I'm pretty
sure there's quite a few more architectures with the same issue.