From: Nathan Lynch <ntl@pobox.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Containers <containers@lists.linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
hpa@zytor.com, mingo@elte.hu, torvalds@linux-foundation.org,
Alexey Dobriyan <adobriyan@gmail.com>,
Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [RFC][v5][PATCH 8/8]: Define clone_with_pids() syscall
Date: Tue, 08 Sep 2009 13:19:08 -0500 [thread overview]
Message-ID: <m3zl95l2oz.fsf@pobox.com> (raw)
In-Reply-To: <20090907211700.GH6685@us.ibm.com> (Sukadev Bhattiprolu's message of "Mon\, 7 Sep 2009 14\:17\:00 -0700")
Suka,
I ran across an issue with this on ppc64.
> +static pid_t *copy_target_pids(void __user *upid_setp)
> +{
> + int j;
> + int rc;
> + int size;
> + int unum_pids; /* # of pids specified by user */
> + int knum_pids; /* # of pids needed in kernel */
> + pid_t *target_pids;
> + struct pid_set pid_set;
> +
> + if (!upid_setp)
> + return NULL;
> +
> + rc = copy_from_user(&pid_set, upid_setp, sizeof(pid_set));
This doesn't work on a 64-bit kernel when the process is 32-bit and uses
the definition of struct pid_set provided in types.h:
+struct pid_set {
+ int num_pids;
+ pid_t *pids;
+};
Shouldn't the pids field be u64 or some other type of fixed size?
next prev parent reply other threads:[~2009-09-08 18:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-07 21:13 [RFC][v5] clone_with_pids() system call Sukadev Bhattiprolu
2009-09-07 21:13 ` [RFC][v5][PATCH 1/8]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-07 21:14 ` [RFC][v5][PATCH 2/8]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-09-07 21:14 ` [RFC][v5][PATCH 3/8] Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-09-07 21:15 ` [RFC][v5][PATCH 4/8]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
2009-09-08 14:16 ` Serge E. Hallyn
2009-09-07 21:15 ` [RFC][v5][PATCH 5/8]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-09-07 21:15 ` [RFC][v5][PATCH 6/8]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-09-07 21:16 ` [RFC][v5][PATCH 7/8]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-07 21:17 ` [RFC][v5][PATCH 8/8]: Define clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-08 18:19 ` Nathan Lynch [this message]
2009-09-09 12:19 ` Arnd Bergmann
2009-09-09 15:51 ` H. Peter Anvin
2009-09-09 18:03 ` Sukadev Bhattiprolu
2009-09-09 18:01 ` H. Peter Anvin
2009-09-09 18:34 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zl95l2oz.fsf@pobox.com \
--to=ntl@pobox.com \
--cc=adobriyan@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sukadev@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox