From: Andi Kleen <ak@muc.de>
To: "Matt D. Robinson" <yakker@aparity.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.40: lkcd (4/9): additional kernel symbols
Date: 05 Oct 2002 02:11:40 +0200 [thread overview]
Message-ID: <m3znttg2wz.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <200210042303.g94N3eS10028@nakedeye.aparity.com>
"Matt D. Robinson" <yakker@aparity.com> writes:
> diff -urN -X /home/bharata/dontdiff linux-2.5.40/arch/i386/kernel/i386_ksyms.c linux-2.5.40+lkcd/arch/i386/kernel/i386_ksyms.c
> --- linux-2.5.40/arch/i386/kernel/i386_ksyms.c Tue Oct 1 12:36:59 2002
> +#if defined(CONFIG_X86) || defined(CONFIG_ALPHA)
> +EXPORT_SYMBOL(page_is_ram);
> +#endif
This ifdef in i386_ksyms.c doesn't make much sense...
> +#ifdef CONFIG_SMP
> +extern irq_desc_t irq_desc[];
> +extern unsigned long irq_affinity[];
> +EXPORT_SYMBOL(irq_affinity);
> +EXPORT_SYMBOL(irq_desc);
> +extern void dump_send_ipi(void);
> +EXPORT_SYMBOL(dump_send_ipi);
> +extern int (*dump_ipi_function_ptr)(struct pt_regs *);
> +EXPORT_SYMBOL(dump_ipi_function_ptr);
> +extern void (*dump_trace_ptr)(struct pt_regs *);
> +EXPORT_SYMBOL(dump_trace_ptr);
> +extern void show_this_cpu_state(int, struct pt_regs *, struct task_struct *);
> +EXPORT_SYMBOL(show_this_cpu_state);
Before adding all these ugly declarations I would just declare the file where
whey are exported from as 'x-obj' and put them directly to where the
functions live.
-Andi
next prev parent reply other threads:[~2002-10-05 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-04 23:03 [PATCH] 2.5.40: lkcd (4/9): additional kernel symbols Matt D. Robinson
2002-10-05 0:11 ` Andi Kleen [this message]
2002-10-05 1:25 ` Matt D. Robinson
2002-10-05 1:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3znttg2wz.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=yakker@aparity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox