* [PATCH] mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment
@ 2024-10-29 8:00 Tudor Ambarus
2024-11-07 18:00 ` Pratyush Yadav
2024-11-11 11:21 ` Tudor Ambarus
0 siblings, 2 replies; 3+ messages in thread
From: Tudor Ambarus @ 2024-10-29 8:00 UTC (permalink / raw)
To: pratyush; +Cc: mwalle, linux-mtd, linux-kernel, Tudor Ambarus
Commit d35df77707bf ("mtd: spi-nor: winbond: fix w25q128 regression")
upstream fixed a regression for flavors of 0xef4018 flash that don't
define SFDP tables. Add a comment on the flash definition highlighting
that there are flavors of flashes with and without SFDP support.
It spares developers searching the entire git log for when we'll better
handle these cases.
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
drivers/mtd/spi-nor/winbond.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 9f7ce5763e71..8d0a00d69e12 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -129,6 +129,7 @@ static const struct flash_info winbond_nor_parts[] = {
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
}, {
.id = SNOR_ID(0xef, 0x40, 0x18),
+ /* Flavors w/ and w/o SFDP. */
.name = "w25q128",
.size = SZ_16M,
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
--
2.47.0.163.g1226f6d8fa-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment
2024-10-29 8:00 [PATCH] mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment Tudor Ambarus
@ 2024-11-07 18:00 ` Pratyush Yadav
2024-11-11 11:21 ` Tudor Ambarus
1 sibling, 0 replies; 3+ messages in thread
From: Pratyush Yadav @ 2024-11-07 18:00 UTC (permalink / raw)
To: Tudor Ambarus; +Cc: pratyush, mwalle, linux-mtd, linux-kernel
On Tue, Oct 29 2024, Tudor Ambarus wrote:
> Commit d35df77707bf ("mtd: spi-nor: winbond: fix w25q128 regression")
> upstream fixed a regression for flavors of 0xef4018 flash that don't
> define SFDP tables. Add a comment on the flash definition highlighting
> that there are flavors of flashes with and without SFDP support.
> It spares developers searching the entire git log for when we'll better
> handle these cases.
Acked-by: Pratyush Yadav <pratyush@kernel.org>
--
Regards,
Pratyush Yadav
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment
2024-10-29 8:00 [PATCH] mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment Tudor Ambarus
2024-11-07 18:00 ` Pratyush Yadav
@ 2024-11-11 11:21 ` Tudor Ambarus
1 sibling, 0 replies; 3+ messages in thread
From: Tudor Ambarus @ 2024-11-11 11:21 UTC (permalink / raw)
To: pratyush, Tudor Ambarus; +Cc: mwalle, linux-mtd, linux-kernel
On Tue, 29 Oct 2024 08:00:49 +0000, Tudor Ambarus wrote:
> Commit d35df77707bf ("mtd: spi-nor: winbond: fix w25q128 regression")
> upstream fixed a regression for flavors of 0xef4018 flash that don't
> define SFDP tables. Add a comment on the flash definition highlighting
> that there are flavors of flashes with and without SFDP support.
> It spares developers searching the entire git log for when we'll better
> handle these cases.
>
> [...]
Applied to git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git,
spi-nor/next branch. Thanks!
[1/1] mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment
https://git.kernel.org/mtd/c/f8f6224948d8
Cheers,
--
Tudor Ambarus <tudor.ambarus@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-11 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29 8:00 [PATCH] mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment Tudor Ambarus
2024-11-07 18:00 ` Pratyush Yadav
2024-11-11 11:21 ` Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox