From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2D1DC4332F for ; Mon, 13 Nov 2023 12:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229876AbjKMMou (ORCPT ); Mon, 13 Nov 2023 07:44:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjKMMos (ORCPT ); Mon, 13 Nov 2023 07:44:48 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09205D4C for ; Mon, 13 Nov 2023 04:44:46 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 021C1C433C7; Mon, 13 Nov 2023 12:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699879485; bh=w3mr6OS81onuZnbxek6iE46F/Yw752xlsfKCcXvPfNI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=t9usVa5S4OmnwAAuzjCR79ebBTaskvZZ9Isi7UgVdnSROSsKbiy3WE3nZEYblK783 XtWGzMS4uHlC8l0TgBkKETmvzFm688u+EJkSTCt8yx4Ek20X7wbKYBEuiB1Wwausb6 y6bN7k9C4rVHjHF8YqS0cWaR1f3pRIZwCmpCbj3o2l5whtxLs8bnAXI7L4bdKouqIu sNMb826dW75AUcBycR1L9osIxUeOKHIGJisWeDo5be5qcLUYzPgj/LUtsSOukwLpsS 5zAz+GFXvuvQDVjIsD0j5gy/oN1UYpKJ2oFJ11k22Ov6wkZM7SY2wdk4LhHbLB6FVs bpNygWAWkbeWg== From: Pratyush Yadav To: Michael Walle Cc: AceLan Kao , Tudor Ambarus , Pratyush Yadav , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mika Westerberg , Dhruva Gole , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported In-Reply-To: <7fbd05e9683e7c79d7d9ef1bf2cec5e8@walle.cc> (Michael Walle's message of "Thu, 09 Nov 2023 11:57:48 +0100") References: <20231108094303.46303-1-acelan.kao@canonical.com> <20231108094303.46303-2-acelan.kao@canonical.com> <7fbd05e9683e7c79d7d9ef1bf2cec5e8@walle.cc> Date: Mon, 13 Nov 2023 13:44:42 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Thu, Nov 09 2023, Michael Walle wrote: >> From: "Chia-Lin Kao (AceLan)" >> When the software reset command isn't supported, we now stop reporting >> the warning message to avoid unnecessary warnings and potential confusion. >> Reviewed-by: Dhruva Gole >> Signed-off-by: Chia-Lin Kao (AceLan) > > Reviewed-by: Michael Walle I did read your reply on the previous thread but did not find time to write a response. I do largely see sense in your argument though I have not fully thought it through yet. But I think it would be great if we can ask the controller "do we need to do a soft reset?" Anyway, I do not think this patch does anything too bad so it is probably not worth debating so much on. So for now, Acked-by: Pratyush Yadav -- Regards, Pratyush Yadav