From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92355139579 for ; Fri, 14 Nov 2025 16:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763137955; cv=none; b=dvYvr0KzyboaooztRiJQCFIxz0PVqbniHjc4GRRhiUI65XxMDYBQvoJqJFLqgSny0PZmFxUwlq70qwTBb2KFogTY+NHDBPlkPoOTY2Ji+ep4OnjcQI6Q2F4trJrjS1Xx5X7nYvuqyLgsUzwsoc8e//jZJWa0mlbvyiCRx/7C53M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763137955; c=relaxed/simple; bh=VPIlJaSoX5ApbSW0ibgqxOo/U0FezlELx52crz4R/Qw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=IN90QtH+sEu9KrQzZg5ZTEHhyCAfF850miCm9nYjaYKSmeEhEVknJA9E3cG/ENAbQkMshu4z6VB4mvDt+vo9Wkm43fstwzvTl+Rosfpom3KSwoVpourHhma5n6lmnZgpPP4hYcxcUsnyL41Nz3P1/5rNV/aqzTdoh+4M55eEoUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N7e/jaZ+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N7e/jaZ+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0422BC4CEF8; Fri, 14 Nov 2025 16:32:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763137955; bh=VPIlJaSoX5ApbSW0ibgqxOo/U0FezlELx52crz4R/Qw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=N7e/jaZ+rMWOwEHCWLLgn6TMigcFke3ePmjNIwetydBBTKGd+F39vf5npz3H7ILEq 1B4TPnvmHW7mYSeZPzXCqQza7p6mwzOwSj8Pb3VNtz6bW0QAT/sfippM7ZBNKXQM0E SYTCq5iaEJuOJmn3jqeBx9l59iFsODi39WZ1liTj25QMX7P6okhIqHvX8VhY3FH6/U 45xztb/IbpZEQDvTL8E2xOIcS822cEatwoJr4O+GRut/NBwbGi5yVPpWW30iakoBQD Os6KkfwnXowUl1q7K/F1hw4shvEth2riUW5WKPyO/yRcK2ZkQZA2IVo/hNwla0nkqE flvpsX0Db+vTQ== From: Pratyush Yadav To: Pasha Tatashin Cc: akpm@linux-foundation.org, bhe@redhat.com, rppt@kernel.org, jasonmiu@google.com, arnd@arndb.de, coxu@redhat.com, dave@vasilevsky.ca, ebiggers@google.com, graf@amazon.com, kees@kernel.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v1 02/13] kho: Convert __kho_abort() to return void In-Reply-To: <20251114155358.2884014-3-pasha.tatashin@soleen.com> (Pasha Tatashin's message of "Fri, 14 Nov 2025 10:53:47 -0500") References: <20251114155358.2884014-1-pasha.tatashin@soleen.com> <20251114155358.2884014-3-pasha.tatashin@soleen.com> Date: Fri, 14 Nov 2025 17:32:31 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Nov 14 2025, Pasha Tatashin wrote: > The internal helper __kho_abort() always returns 0 and has no failure > paths. Its return value is ignored by __kho_finalize and checked > needlessly by kho_abort. > > Change the return type to void to reflect that this function cannot > fail, and simplify kho_abort by removing dead error handling code. > > Signed-off-by: Pasha Tatashin Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav