From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 049A318EFD1 for ; Fri, 14 Nov 2025 19:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763148838; cv=none; b=Bz+qppEdAErxkocJSdzqTtiDTpO8pMe9KUFEKkjZuBJqydoqz1ZyEPXstcJSW+HFSsSVO7ljRnQ5oY+Sl9k8PtXvl4Q57WlWZqN3ev/4RWV6yOODWUeQ/3CqHy+OrwLXXEvzVq5d4naBA33x5DYNYOvL5C6hT0L1FIvn2YWySNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763148838; c=relaxed/simple; bh=FZlWl6qWs90L/x6LrsaPXbIv40QuDF4Bq+k9+9iwvHM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=pBBWu/sXZjBm/K7w6hr/j47jyDMu4Vt0YpX/NygOJb1ueUlm864maa9zQu2td/HBc1HFQQipNcSACghwGjAAkJI2K6eQJ1RZA1g0Q3UmnPh1STrrHdhPpzBBzEbhwntUS3QTgNON15uYjj/1B3gd7AOdZHdEJjgTzqeCGRCaMck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H/FCBFq3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H/FCBFq3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 897F6C113D0; Fri, 14 Nov 2025 19:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763148837; bh=FZlWl6qWs90L/x6LrsaPXbIv40QuDF4Bq+k9+9iwvHM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H/FCBFq3BK4sRDRlJS4qxqxbkJ04z3EUmWnL6nfcRTAYLPQs5LsCcx0P0FWqIeXBf EY4XCIsjOOtT/LhGn/3+JTNCV2epPhgMYFzcg/B7EJmKYtDDzrxeYBgNF8+EcMvmUu p4kdbKdYGEPxNOhITYECmyOfJXmBaBqcCx/tDY/UOy66N/SiDku0pMAT9lM72+Wdgt pnwpKrcyu0OrIYe74l6RQoS896GojkRIgnZtH7zJ1duMnhTVAKcHb5HwvRcgBNzeXc SzfLqHK/QJEkleADVWXk/ByhAxt7eS4kOINLelj8lcf82ZQmCThm5QSwxz2/DNffuf b/rZhOGN5SPqQ== From: Pratyush Yadav To: Pasha Tatashin Cc: akpm@linux-foundation.org, bhe@redhat.com, rppt@kernel.org, jasonmiu@google.com, arnd@arndb.de, coxu@redhat.com, dave@vasilevsky.ca, ebiggers@google.com, graf@amazon.com, kees@kernel.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v2 05/13] kho: Verify deserialization status and fix FDT alignment access In-Reply-To: <20251114190002.3311679-6-pasha.tatashin@soleen.com> (Pasha Tatashin's message of "Fri, 14 Nov 2025 13:59:54 -0500") References: <20251114190002.3311679-1-pasha.tatashin@soleen.com> <20251114190002.3311679-6-pasha.tatashin@soleen.com> Date: Fri, 14 Nov 2025 20:33:54 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Nov 14 2025, Pasha Tatashin wrote: > During boot, kho_restore_folio() relies on the memory map having been > successfully deserialized. If deserialization fails or no map is > present, attempting to restore the FDT folio is unsafe. > > Update kho_mem_deserialize() to return a boolean indicating success. Use > this return value in kho_memory_init() to disable KHO if deserialization > fails. Also, the incoming FDT folio is never used, there is no reason to > restore it. > > Additionally, use get_unaligned() to retrieve the memory map pointer > from the FDT. FDT properties are not guaranteed to be naturally aligned, > and accessing a 64-bit value via a pointer that is only 32-bit aligned > can cause faults. > > Signed-off-by: Pasha Tatashin > Reviewed-by: Mike Rapoport (Microsoft) Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav