From: Pratyush Yadav <pratyush@kernel.org>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mtd: spi-nor: Improve reporting for software reset failures
Date: Thu, 26 Oct 2023 15:39:54 +0200 [thread overview]
Message-ID: <mafs0fs1xmrit.fsf@kernel.org> (raw)
In-Reply-To: <20231026012017.518610-1-acelan.kao@canonical.com> (AceLan Kao's message of "Thu, 26 Oct 2023 09:20:17 +0800")
On Thu, Oct 26 2023, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
>
> When the software reset command isn't supported, we now report it
> as an informational message(dev_info) instead of a warning(dev_warn).
> This adjustment helps avoid unnecessary alarm and confusion regarding
> software reset capabilities.
I still think the soft reset command deserves a warn, and not an info.
Because it _is_ a bad thing if you need to soft reset and are unable to
do so. Your bootloader (or linux if you rmmod and modprobe again) might
not be able to detect the flash mode and operate it properly.
I think we should just not unconditionally run this and instead only
call it when the flash reset is not connected -- that is only call this
under a check for SNOR_F_BROKEN_RESET, like we do for 4-byte addressing
mode.
I don't have a strong opposition to this patch but I do think it is
fixing the problem in the wrong place.
[...]
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2023-10-26 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 1:20 [PATCH v4] mtd: spi-nor: Improve reporting for software reset failures AceLan Kao
2023-10-26 6:11 ` Dhruva Gole
2023-10-26 6:21 ` AceLan Kao
2023-10-26 6:28 ` Michael Walle
2023-10-26 10:08 ` AceLan Kao
2023-10-26 13:39 ` Pratyush Yadav [this message]
2023-10-26 15:02 ` Michael Walle
2023-11-06 13:20 ` Pratyush Yadav
2023-11-06 14:27 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0fs1xmrit.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=acelan.kao@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox