From: Pratyush Yadav <pratyush@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Parth Pancholi <parth105105@gmail.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Parth Pancholi <parth.pancholi@toradex.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: macronix: remove mx25u25635f from parts list to enable SFDP
Date: Mon, 25 Nov 2024 13:59:32 +0000 [thread overview]
Message-ID: <mafs0iksb5s8r.fsf@kernel.org> (raw)
In-Reply-To: <0525af7c-f9a9-4dfc-9fed-97efc438b2b8@linaro.org> (Tudor Ambarus's message of "Mon, 11 Nov 2024 10:49:12 +0000")
On Mon, Nov 11 2024, Tudor Ambarus wrote:
> On 11/5/24 10:58 AM, Parth Pancholi wrote:
>> From: Parth Pancholi <parth.pancholi@toradex.com>
>>
>> The Macronix mx25u25635f flash device supports SFDP initialization.
>> This commit removes the specific mx25u25635f entry (NOR ID 0xc22539),
>> along with its size and flags, from the NOR parts list. By removing
>> this entry, both mx25u25635f and mx25u25645g (which share the same
>> NOR ID) will utilize the generic flash driver configuration.
>>
>> This change allows both devices (mx25u25635f and mx25u25645g) to
>> leverage SFDP-defined parameters, enabling dual and quad read
>> operations without the need for manual adjustment of no_sfdp_flags.
>
> I'm fine with this. We may re-add an entry when BP is used or if someone
> reports there's a flash with this ID that doesn't support SFDP, which
> has a reasonable amount of probability for macronix flashes, but I'm ok
> taking the risk and fixing it afterwards if reported.
Sounds good. Would be a good idea to queue it early after -rc1 so it
gets some time to bake in linux-next.
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2024-11-25 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 10:58 [PATCH v2] mtd: spi-nor: macronix: remove mx25u25635f from parts list to enable SFDP Parth Pancholi
2024-11-11 10:49 ` Tudor Ambarus
2024-11-25 13:59 ` Pratyush Yadav [this message]
2024-12-06 16:14 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0iksb5s8r.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=parth.pancholi@toradex.com \
--cc=parth105105@gmail.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox