Re: [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback

Pratyush Yadav
2024-05-27T13:27:13Z

Hi,

On Fri, Apr 19 2024, Michael Walle wrote:

> With the removal of the Xilinx flashes, there is no more flash driver
> using that hook. The original intention was to let the driver configure
> special requirements like page size an opcodes. This is already
> possible by other means and it is unlikely a flash will overwrite the
> (more or less complex) setup function.

Just for comparison, I checked if U-Boot does anything with the setup
hook that we might also need. It looks like it mostly uses it for
handling non-uniform erases on Spansion flashes, since U-Boot doesn't
have proper support for them. This shouldn't be needed by Linux since it
can already do those erases.

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

--
Regards,
Pratyush Yadav