Re: [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()

Michael Walle
2024-04-22T09:53:48Z

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi,

> if (name)
> info = spi_nor_match_name(nor, name);
>
> if (!info || info->id) {
> jinfo = spi_nor_detect(nor);
> if (IS_ERR(jinfo))
> return jinfo;
>
> if (jinfo != info)

info could be NULL here. So "info &&", apart from that looks good.

> dev_warn(();
> info = jinfo;
> }

Pratyush, should I'll drop your Rb tag then.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]