Re: [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()

Tudor Ambarus
2024-04-22T10:12:08Z

On 4/22/24 10:53, Michael Walle wrote:
> Hi,
>
>> if (name)
>> info = spi_nor_match_name(nor, name);
>>
>> if (!info || info->id) {

here

>> jinfo = spi_nor_detect(nor);
>> if (IS_ERR(jinfo))
>> return jinfo;
>>
>> if (jinfo != info)
>
> info could be NULL here. So "info &&", apart from that looks good.

it can't be NULL, the parent if indicated above assures info isn't NULL

>
>> dev_warn(();
>> info = jinfo;
>> }
>
> Pratyush, should I'll drop your Rb tag then.
>
> -michael