From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3410A235BE4 for ; Mon, 13 Jan 2025 13:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736775635; cv=none; b=CcUGhN2SLLJ0HCT1fqPpwqsk3pYSszmNgrT1xUN2B4uYP9vP3eMLi/039wmTei966FId5s0GfGG8mNhkqEXMoE9YC4RT6SA+ZuZCRqTVBFNIYLZ3afV1/GbmLrhGpaJPP7ei6CJBZfhvB8HUY394mv3ulct5leFZFsvDa52GbN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736775635; c=relaxed/simple; bh=B+07sCY10tpw21NMC2JISBSUbjbJMcqCQOLgT04sJtg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=JvFsnWyzJSsLdCJmtbkmG6StQ00I4I08kvFgWqvVs0Ob9+hWWcWbvh3pvLAGSZ1LL/2LJ8D9js4EdlvVDHo23bZpZOiGy5kTz8GlLCRpVIJHLeHA201RNKgngIw3JpPUaNDXnI1aae50zhzvC6ufWvfLyZokv/F+jkMFkkO6CfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qPpkfcOd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qPpkfcOd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3EF7C4CED6; Mon, 13 Jan 2025 13:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736775635; bh=B+07sCY10tpw21NMC2JISBSUbjbJMcqCQOLgT04sJtg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qPpkfcOdv3FaNeKTpPahHgpYJ98rqlGyiiQffLhCs2dgx+J/S3ssw/19DNwRaGrOh n3xqsc4ySn/JRsJNCEZ+rC3yrVWF8AjWGSVm9dyXfVJ3T9OmHpa1eCR+5ovsk9SBK5 sihyI2FL6D8qlyg3tVEcBzeGbXz1H0g0+b6nZfJtmN3TrnK6IKm9Z68sJGJaATh1Iy k5umLuwidB3UiN3V5qmhA1WKBMrIC8ib+pdQ2B8SzPAOtq6jJxbFezRzVprTJpvwMl Xj7ZrHxhzeiCO6BOIiGe+gIPrCkc8b/6f+8kHHVcclestmsrusje3z2sMgIbYkVOfB DKDrKGJiXBQtg== From: Pratyush Yadav To: Miquel Raynal Cc: Pratyush Yadav , Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Thomas Petazzoni , Steam Lin , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mtd: spi-nor: winbond: Add support for w25q01jv In-Reply-To: <87ed1carsk.fsf@bootlin.com> (Miquel Raynal's message of "Thu, 09 Jan 2025 17:14:03 +0100") References: <20241224-winbond-6-12-rc1-nor-volatile-bit-v1-0-f7c4dff66182@bootlin.com> <20241224-winbond-6-12-rc1-nor-volatile-bit-v1-1-f7c4dff66182@bootlin.com> <87ed1carsk.fsf@bootlin.com> Date: Mon, 13 Jan 2025 13:40:32 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Jan 09 2025, Miquel Raynal wrote: > Hello Pratyush, > >>> + }, { >>> + .id = SNOR_ID(0xef, 0x40, 0x21), >>> + .name = "w25q01jv", >> >> We no longer set the name for new flash entries. But knowing the flash >> name for an entry is still useful, so make this a comment on top of the >> entry. > > I just connected the dots and understood your request. I will respin a > series will all your comments addressed. Thanks! Yeah sorry, I was on vacation and didn't get around to opening my computer too often. Your v3 gets my suggestion right, thanks! -- Regards, Pratyush Yadav