From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574313090E8 for ; Thu, 20 Nov 2025 09:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763630493; cv=none; b=jTFMa+3WeROBAvLlHu1bCyoy3gBX8Oqm8y4wmq+FC138XbMni1+VO+znRJLuZ5qxznXhZ2jnKmxmNn9+dL/5OcY10IdsG+8ijy3AWfxfCokzyZM0gCWVogvj0a338xHgXMRnANfAx147fpBqLSOLUXx4i6PB7wFd3f4b0jLfJBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763630493; c=relaxed/simple; bh=qExihDuno7MaUro6s8FSJYa8KtjgfePenn0sjuTqV9s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=usovwtdebONYGepkhsox1CqJIu+8UI/BidJaqiAGxM8oPFEFlc1Y4spGIqd5MbquFomSuokv1jEnK4rBdUWM8qzNw3H0/D2qU7N7/g3Bpn92eOtOjhJqiQyLh1pOMJw7YoBKyG3Nh43BBI9ix3EQQbzAT3nBamVRxzlek+ho588= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eu0rkwm4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eu0rkwm4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69759C116B1; Thu, 20 Nov 2025 09:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763630492; bh=qExihDuno7MaUro6s8FSJYa8KtjgfePenn0sjuTqV9s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=eu0rkwm4OBhsJQEJ00dt0+Lu8W7F8Xg4qqtuoQiXLuc7+DVYohnk+hBynpVP84HCo 6va4jxO0d2DFSzImL/zm7JxlR0CKNPehqnSq/KA27pgEZqlBnEgVkmRUzhkO6vKWsA 4zGwzDAiMNtewJneTXI2NcaND2UFiWBZCWdiO793ZNhKru4FzNo30AEq45vj78cSCI U8Z/iDCQidE84ggxTX1yRdVvyUmgHxYRiPuWVeB6peTPUAfzzI1bTgxDkqXRV04Bj9 O0FibFGbf2QjoPt4zKGcP4tl8MKahPARfvWzscDk+GGESNDrjDIhszZIjM+rhvh6Fm OO/SQekExeOAw== From: Pratyush Yadav To: Markus Elfring Cc: Pratyush Yadav , kexec@lists.infradead.org, linux-mm@kvack.org, Alexander Graf , Andrew Morton , David Matlack , Mike Rapoport , Pasha Tatashin , LKML Subject: Re: [PATCH] kho: free chunks using free_page() instead of kfree() In-Reply-To: (Markus Elfring's message of "Wed, 19 Nov 2025 21:06:49 +0100") References: <20251118182218.63044-1-pratyush@kernel.org> Date: Thu, 20 Nov 2025 10:21:30 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Nov 19 2025, Markus Elfring wrote: > =E2=80=A6 >> When the commit switched to using the buddy allocator directly, it >> missed updating kho_mem_ser_free() to use free_page() instead of >> kfree(). > > Would another imperative wording become helpful for an improved change de= scription? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D= ocumentation/process/submitting-patches.rst?h=3Dv6.18-rc6#n94 "the commit" here refers to the commit fa759cd75bce5 ("kho: allocate metadata directly from the buddy allocator"), not "this commit"/"this patch". I figured that can be understood from the context and I won't need to spell the whole thing out again. I don't understand the technicalities of the English grammar so well, but IIUC imperative mood is used in sentences that give a command. This paragraph talks about a past event. Anyway, if you have something better, happy to take suggestions. --=20 Regards, Pratyush Yadav