Re: [PATCH v2] mtd: spi-nor: core: correct type of i

Muhammad Usama Anjum
2024-03-12T12:15:58Z

On 3/12/24 5:14 PM, Pratyush Yadav wrote:
> Hi,
>
> On Mon, Mar 11 2024, Muhammad Usama Anjum wrote:
>
>> Soft reminder
>
> Miquel should pick up the patch when sending out his pull request [0].
>
> [0] https://lore.kernel.org/linux-mtd/20240307180919.4cb7a4cb@xps-13/
Thanks Pratyush!

>
>>
>> On 3/4/24 2:01 PM, Muhammad Usama Anjum wrote:
>>> The i should be signed to find out the end of the loop. Otherwise,
>>> i >= 0 is always true and loop becomes infinite. Make its type to be
>>> int.
>>>
>>> Fixes: 6a9eda34418f ("mtd: spi-nor: core: set mtd->eraseregions for non-uniform erase map")
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>> Changes since v1:
>>> - Make i int instead of u8
>>> ---
>>> drivers/mtd/spi-nor/core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
>>> index 65b32ea59afc6..3e1f1913536bf 100644
>>> --- a/drivers/mtd/spi-nor/core.c
>>> +++ b/drivers/mtd/spi-nor/core.c
>>> @@ -3373,7 +3373,7 @@ static u32
>>> spi_nor_get_region_erasesize(const struct spi_nor_erase_region *region,
>>> const struct spi_nor_erase_type *erase_type)
>>> {
>>> - u8 i;
>>> + int i;
>>>
>>> if (region->overlaid)
>>> return region->size;
>

--
BR,
Muhammad Usama Anjum