From: Pratyush Yadav <pratyush@kernel.org>
To: Jakub Czapiga <czapiga@google.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Konrad Adamczyk <konrada@google.com>,
Adeel Arshad <adeel.arshad@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Kornel Duleba <korneld@google.com>
Subject: Re: [PATCH v2] mtd: spi-nor: core: Check read CR support
Date: Tue, 18 Nov 2025 13:34:59 +0100 [thread overview]
Message-ID: <mafs0v7j74iz0.fsf@kernel.org> (raw)
In-Reply-To: <20250919181547.2172319-1-czapiga@google.com> (Jakub Czapiga's message of "Fri, 19 Sep 2025 18:15:47 +0000")
On Fri, Sep 19 2025, Jakub Czapiga wrote:
> Some SPI controllers like Intel's one on the PCI bus do not support
> opcode 35h. This opcode is used to read the Configuration Register on
> SPI-NOR chips that have 16-bit Status Register configured regardless
> of the controller support for it. Adding a check call in the setup step
> allows disabling use of the 35h opcode and falling back to the manual
> Status Registers management.
>
> Before:
> openat(AT_FDCWD, "/dev/mtd0", O_RDWR) = 4
> ioctl(4, MIXER_WRITE(6) or MEMUNLOCK, {start=0, length=0x2000000}) = -1
> EOPNOTSUPP
>
> After:
> openat(AT_FDCWD, "/dev/mtd0", O_RDWR) = 4
> ioctl(4, MIXER_WRITE(6) or MEMUNLOCK, {start=0, length=0x2000000}) = 0
> ioctl(4, MIXER_WRITE(5) or MEMLOCK, {start=0x1800000, length=0x800000}) = 0
>
> Suggested-by: Adeel Arshad <adeel.arshad@intel.com>
> Signed-off-by: Jakub Czapiga <czapiga@google.com>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
Applied to spi-nor/next. Thanks!
BTW, b4 complains that DKIM fails on your email. Please check.
[...]
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2025-11-18 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 18:15 [PATCH v2] mtd: spi-nor: core: Check read CR support Jakub Czapiga
2025-11-18 12:34 ` Pratyush Yadav [this message]
2025-11-18 14:20 ` Konstantin Ryabitsev
2025-11-20 9:27 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0v7j74iz0.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=adeel.arshad@intel.com \
--cc=czapiga@google.com \
--cc=konrada@google.com \
--cc=korneld@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox