From: Milton Miller <miltonm@bga.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] sched domain sysctl: register online cpus
Date: Fri, 12 Oct 2007 04:35:18 -0500 (CDT) [thread overview]
Message-ID: <mm-sched-1@bga.com> (raw)
In-Reply-To: <mm-sched-0@bga.com>
init_sched_domain_sysctl was walking cpus 0-n and referencing per_cpu
variables. If the cpus_possible mask is not contigious this will result
in a crash referencing unallocated data. If the online mask is not
contigious then we would show offline cpus and miss online ones.
Signed-off-by: Milton Miller <miltonm@bga.com>
Index: kernel/kernel/sched.c
===================================================================
--- kernel.orig/kernel/sched.c 2007-10-11 23:48:10.000000000 -0500
+++ kernel/kernel/sched.c 2007-10-11 23:55:51.000000000 -0500
@@ -5367,11 +5367,12 @@ static void init_sched_domain_sysctl(voi
sd_ctl_dir[0].child = entry;
- for (i = 0; i < cpu_num; i++, entry++) {
+ for_each_online_cpu(i) {
snprintf(buf, 32, "cpu%d", i);
entry->procname = kstrdup(buf, GFP_KERNEL);
entry->mode = 0555;
entry->child = sd_alloc_ctl_cpu_table(i);
+ entry++;
}
sd_sysctl_header = register_sysctl_table(sd_ctl_root);
}
next prev parent reply other threads:[~2007-10-12 9:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 9:34 [PATCH] sched domain debug sysctl fixes Milton Miller
2007-10-12 9:35 ` [PATCH] sched.c: use kcalloc Milton Miller
2007-10-12 9:35 ` Milton Miller [this message]
2007-10-12 9:35 ` [PATCH] sched domain sysctl: free and rebuild when changing domains Milton Miller
2007-10-12 9:35 ` [PATCH] sched domain sysctl: don't bug on alloc failure Milton Miller
2007-10-12 9:35 ` [PATCH] sched domain sysctl: sysctl tables can have no holes Milton Miller
2007-10-12 9:54 ` [PATCH] sched domain debug sysctl fixes Milton Miller
2007-10-15 7:47 ` Ingo Molnar
2007-10-15 23:40 ` [PATCH] sched domain sysctl: free kstrdup allocations Milton Miller
2007-10-16 8:44 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mm-sched-1@bga.com \
--to=miltonm@bga.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox