* Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c
@ 2015-07-04 7:44 Vinson Lee
2015-07-05 15:35 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Vinson Lee @ 2015-07-04 7:44 UTC (permalink / raw)
To: Pablo Neira Ayuso, Patrick McHardy, Jozsef Kadlecsik,
David S. Miller, Sergey Popovich, Anton Danilov
Cc: netfilter-devel, coreteam, Netdev, LKML
Hi.
With the latest Linux 4.2-rc1, I am hitting this build error with GCC
4.4.7 on CentOS 6.
CC net/netfilter/ipset/ip_set_hash_netnet.o
net/netfilter/ipset/ip_set_hash_netnet.c: In function ‘hash_netnet4_uadt’:
net/netfilter/ipset/ip_set_hash_netnet.c:163: error: unknown field
‘cidr’ specified in initializer
net/netfilter/ipset/ip_set_hash_netnet.c:163: warning: missing braces
around initializer
net/netfilter/ipset/ip_set_hash_netnet.c:163: warning: (near
initialization for ‘e.<anonymous>.ip’)
net/netfilter/ipset/ip_set_hash_netnet.c: In function ‘hash_netnet6_uadt’:
net/netfilter/ipset/ip_set_hash_netnet.c:388: error: unknown field
‘cidr’ specified in initializer
net/netfilter/ipset/ip_set_hash_netnet.c:388: warning: missing braces
around initializer
net/netfilter/ipset/ip_set_hash_netnet.c:388: warning: (near
initialization for ‘e.ip[0]’)
Cheers,
Vinson
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c
2015-07-04 7:44 Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c Vinson Lee
@ 2015-07-05 15:35 ` Guenter Roeck
2015-07-13 16:13 ` Akemi Yagi
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2015-07-05 15:35 UTC (permalink / raw)
To: Vinson Lee
Cc: Pablo Neira Ayuso, Patrick McHardy, Jozsef Kadlecsik,
David S. Miller, Sergey Popovich, Anton Danilov, netfilter-devel,
coreteam, Netdev, LKML
On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote:
> Hi.
>
> With the latest Linux 4.2-rc1, I am hitting this build error with GCC
> 4.4.7 on CentOS 6.
>
> CC net/netfilter/ipset/ip_set_hash_netnet.o
> net/netfilter/ipset/ip_set_hash_netnet.c: In function ‘hash_netnet4_uadt’:
> net/netfilter/ipset/ip_set_hash_netnet.c:163: error: unknown field
> ‘cidr’ specified in initializer
> net/netfilter/ipset/ip_set_hash_netnet.c:163: warning: missing braces
> around initializer
> net/netfilter/ipset/ip_set_hash_netnet.c:163: warning: (near
> initialization for ‘e.<anonymous>.ip’)
> net/netfilter/ipset/ip_set_hash_netnet.c: In function ‘hash_netnet6_uadt’:
> net/netfilter/ipset/ip_set_hash_netnet.c:388: error: unknown field
> ‘cidr’ specified in initializer
> net/netfilter/ipset/ip_set_hash_netnet.c:388: warning: missing braces
> around initializer
> net/netfilter/ipset/ip_set_hash_netnet.c:388: warning: (near
> initialization for ‘e.ip[0]’)
>
Previously fixed with commit 1a869205c75cb ("netfilter: ipset: The unnamed union
initialization may lead to compilation error"), reintroduced with commit
aff227581ed1a ("netfilter: ipset: Check CIDR value only when attribute is given").
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c
2015-07-05 15:35 ` Guenter Roeck
@ 2015-07-13 16:13 ` Akemi Yagi
2015-07-13 18:17 ` Cong Wang
0 siblings, 1 reply; 5+ messages in thread
From: Akemi Yagi @ 2015-07-13 16:13 UTC (permalink / raw)
To: linux-kernel; +Cc: netfilter-devel, netdev, netfilter-devel, linux-kernel
On Sun, 05 Jul 2015 08:35:20 -0700, Guenter Roeck wrote:
> On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote:
>> Hi.
>>
>> With the latest Linux 4.2-rc1, I am hitting this build error with GCC
>> 4.4.7 on CentOS 6.
>>
>> CC net/netfilter/ipset/ip_set_hash_netnet.o
>> net/netfilter/ipset/ip_set_hash_netnet.c: In function
>> ‘hash_netnet4_uadt’:
>> net/netfilter/ipset/ip_set_hash_netnet.c:163: error: unknown field
>> ‘cidr’ specified in initializer
>> net/netfilter/ipset/ip_set_hash_netnet.c:163: warning: missing braces
>> around initializer net/netfilter/ipset/ip_set_hash_netnet.c:163:
>> warning: (near initialization for ‘e.<anonymous>.ip’)
>> net/netfilter/ipset/ip_set_hash_netnet.c: In function
>> ‘hash_netnet6_uadt’:
>> net/netfilter/ipset/ip_set_hash_netnet.c:388: error: unknown field
>> ‘cidr’ specified in initializer
>> net/netfilter/ipset/ip_set_hash_netnet.c:388: warning: missing braces
>> around initializer net/netfilter/ipset/ip_set_hash_netnet.c:388:
>> warning: (near initialization for ‘e.ip[0]’)
>>
> Previously fixed with commit 1a869205c75cb ("netfilter: ipset: The
> unnamed union initialization may lead to compilation error"),
> reintroduced with commit aff227581ed1a ("netfilter: ipset: Check CIDR
> value only when attribute is given").
>
> Guenter
I wonder what can be done to get this issue fixed. This problem was seen
in 4.2-rc1 and now in 4.2-rc2 on RHEL-6.6.
$ gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)
Please advise.
Akemi
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c
2015-07-13 16:13 ` Akemi Yagi
@ 2015-07-13 18:17 ` Cong Wang
2015-07-14 17:25 ` Akemi Yagi
0 siblings, 1 reply; 5+ messages in thread
From: Cong Wang @ 2015-07-13 18:17 UTC (permalink / raw)
To: Akemi Yagi
Cc: netdev, netfilter-devel, linux-kernel@vger.kernel.org,
Sergey Popovich
On Mon, Jul 13, 2015 at 9:13 AM, Akemi Yagi <amyagi@gmail.com> wrote:
> On Sun, 05 Jul 2015 08:35:20 -0700, Guenter Roeck wrote:
>
>> On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote:
>>> Hi.
>>>
>>> With the latest Linux 4.2-rc1, I am hitting this build error with GCC
>>> 4.4.7 on CentOS 6.
>>>
>>> CC net/netfilter/ipset/ip_set_hash_netnet.o
>>> net/netfilter/ipset/ip_set_hash_netnet.c: In function
>>> ‘hash_netnet4_uadt’:
>>> net/netfilter/ipset/ip_set_hash_netnet.c:163: error: unknown field
>>> ‘cidr’ specified in initializer
>>> net/netfilter/ipset/ip_set_hash_netnet.c:163: warning: missing braces
>>> around initializer net/netfilter/ipset/ip_set_hash_netnet.c:163:
>>> warning: (near initialization for ‘e.<anonymous>.ip’)
>>> net/netfilter/ipset/ip_set_hash_netnet.c: In function
>>> ‘hash_netnet6_uadt’:
>>> net/netfilter/ipset/ip_set_hash_netnet.c:388: error: unknown field
>>> ‘cidr’ specified in initializer
>>> net/netfilter/ipset/ip_set_hash_netnet.c:388: warning: missing braces
>>> around initializer net/netfilter/ipset/ip_set_hash_netnet.c:388:
>>> warning: (near initialization for ‘e.ip[0]’)
>>>
>> Previously fixed with commit 1a869205c75cb ("netfilter: ipset: The
>> unnamed union initialization may lead to compilation error"),
>> reintroduced with commit aff227581ed1a ("netfilter: ipset: Check CIDR
>> value only when attribute is given").
>>
>> Guenter
>
> I wonder what can be done to get this issue fixed. This problem was seen
> in 4.2-rc1 and now in 4.2-rc2 on RHEL-6.6.
>
Just revert the initializer piece.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c
2015-07-13 18:17 ` Cong Wang
@ 2015-07-14 17:25 ` Akemi Yagi
0 siblings, 0 replies; 5+ messages in thread
From: Akemi Yagi @ 2015-07-14 17:25 UTC (permalink / raw)
To: linux-kernel
On Mon, 13 Jul 2015 11:17:57 -0700, Cong Wang wrote:
> On Mon, Jul 13, 2015 at 9:13 AM, Akemi Yagi <amyagi@gmail.com> wrote:
>> On Sun, 05 Jul 2015 08:35:20 -0700, Guenter Roeck wrote:
>>> Previously fixed with commit 1a869205c75cb ("netfilter: ipset: The
>>> unnamed union initialization may lead to compilation error"),
>>> reintroduced with commit aff227581ed1a ("netfilter: ipset: Check CIDR
>>> value only when attribute is given").
>>>
>>> Guenter
>>
>> I wonder what can be done to get this issue fixed. This problem was
>> seen in 4.2-rc1 and now in 4.2-rc2 on RHEL-6.6.
>>
>>
> Just revert the initializer piece.
Thanks to Jozsef Kadlecsik who posted this response to the netfilter-devel
list:
"As I mentioned at the workshop, the patch
net-netfilter-ipset-work-around-gcc-444-initializer-bug.patch has been
added to the -mm tree at Jun 17. My impression was that that way the bug
was fixed and everything was all right."
The patch is seen here:
https://lkml.org/lkml/2015/7/6/881
Akemi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-14 17:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-04 7:44 Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c Vinson Lee
2015-07-05 15:35 ` Guenter Roeck
2015-07-13 16:13 ` Akemi Yagi
2015-07-13 18:17 ` Cong Wang
2015-07-14 17:25 ` Akemi Yagi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox