* [PATCH] CIFS: Fix build failure with smb2
@ 2017-03-30 10:34 Tobias Regnery
2017-03-30 11:47 ` Aurélien Aptel
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Regnery @ 2017-03-30 10:34 UTC (permalink / raw)
To: sfrench, linux-cifs, linux-kernel; +Cc: Tobias Regnery
I saw the following build error during a randconfig build:
fs/cifs/smb2ops.c: In function 'smb2_new_lease_key':
fs/cifs/smb2ops.c:1104:2: error: implicit declaration of function 'generate_random_uuid' [-Werror=implicit-function-declaration]
Explicit include the right header to fix this issue.
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
This is against next-20170330
fs/cifs/smb2ops.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index c6d14cc44510..c1b70559496c 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -21,6 +21,7 @@
#include <linux/vfs.h>
#include <linux/falloc.h>
#include <linux/scatterlist.h>
+#include <linux/uuid.h>
#include <crypto/aead.h>
#include "cifsglob.h"
#include "smb2pdu.h"
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] CIFS: Fix build failure with smb2
2017-03-30 10:34 [PATCH] CIFS: Fix build failure with smb2 Tobias Regnery
@ 2017-03-30 11:47 ` Aurélien Aptel
2017-04-04 7:23 ` Steve French
0 siblings, 1 reply; 3+ messages in thread
From: Aurélien Aptel @ 2017-03-30 11:47 UTC (permalink / raw)
To: Tobias Regnery, sfrench, linux-cifs, linux-kernel; +Cc: Tobias Regnery
Tobias Regnery <tobias.regnery@gmail.com> writes:
> Explicit include the right header to fix this issue.
uuid.h indeed declares generate_random_uuid(). Looks good to me.
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] CIFS: Fix build failure with smb2
2017-03-30 11:47 ` Aurélien Aptel
@ 2017-04-04 7:23 ` Steve French
0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2017-04-04 7:23 UTC (permalink / raw)
To: linux-cifs@vger.kernel.org, LKML
merged into cifs-2.6.git
thx
On Thu, Mar 30, 2017 at 6:47 AM, Aurélien Aptel
<aurelien.aptel@gmail.com> wrote:
> Tobias Regnery <tobias.regnery@gmail.com> writes:
>> Explicit include the right header to fix this issue.
>
> uuid.h indeed declares generate_random_uuid(). Looks good to me.
>
> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-04 7:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-30 10:34 [PATCH] CIFS: Fix build failure with smb2 Tobias Regnery
2017-03-30 11:47 ` Aurélien Aptel
2017-04-04 7:23 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox