From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760869AbbJ3U7b (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Oct 2015 16:59:31 -0400
Received: from mx2.suse.de ([195.135.220.15]:38490 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759992AbbJ3U73 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Oct 2015 16:59:29 -0400
From: Johannes Thumshirn <jthumshirn@suse.de>
To: tim.gardner@canonical.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jayamohan Kallickal <jayamohan.kallickal@avagotech.com>,
        Minh Tran <minh.tran@avagotech.com>,
        John Soni Jose <sony.john-n@avagotech.com>,
        "James E.J. Bottomley" <JBottomley@odin.com>
Subject: Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check
References: <1446229378-2956-1-git-send-email-tim.gardner@canonical.com>
Date: Fri, 30 Oct 2015 21:59:22 +0100
In-Reply-To: <1446229378-2956-1-git-send-email-tim.gardner@canonical.com> (tim
	gardner's message of "Fri, 30 Oct 2015 12:22:58 -0600")
Message-ID: <mqdbnbgxec5.fsf@linux-x5ow.site>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tim,
tim.gardner@canonical.com writes:

> From: Tim Gardner <tim.gardner@canonical.com>
>
> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>   WARN_ON(!length > 0);
>
> gcc version 5.2.1

This patch (or similar) was already posted on Oct 1 by Joel Stanley.
See http://comments.gmane.org/gmane.linux.scsi/105462

Thanks,
        Johannes