From: Andreas Schwab <schwab@linux-m68k.org>
To: Minjie Du <duminjie@vivo.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-m68k@lists.linux-m68k.org (open list:M68K ARCHITECTURE),
linux-kernel@vger.kernel.org (open list),
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] m68k: apollo: Remove a duplicate assignment in dn_timer_int
Date: Wed, 05 Jul 2023 14:42:18 +0200 [thread overview]
Message-ID: <mvm4jmisf6d.fsf@linux-m68k.org> (raw)
In-Reply-To: <20230705121307.17204-1-duminjie@vivo.com> (Minjie Du's message of "Wed, 5 Jul 2023 20:13:07 +0800")
On Jul 05 2023, Minjie Du wrote:
> Delete a duplicate statement from this function implementation.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> arch/m68k/apollo/config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
> index 42a8b8e2b..5645d2018 100644
> --- a/arch/m68k/apollo/config.c
> +++ b/arch/m68k/apollo/config.c
> @@ -173,7 +173,6 @@ irqreturn_t dn_timer_int(int irq, void *dev_id)
> legacy_timer_tick(1);
> timer_heartbeat();
>
> - x = *(volatile unsigned char *)(apollo_timer + 3);
> x = *(volatile unsigned char *)(apollo_timer + 5);
They are not the same: 3 != 5.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2023-07-05 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 12:13 [PATCH v1] m68k: apollo: Remove a duplicate assignment in dn_timer_int Minjie Du
2023-07-05 12:38 ` Geert Uytterhoeven
2023-07-05 12:42 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm4jmisf6d.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=duminjie@vivo.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=opensource.kernel@vivo.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox