Re: [PATCH v1] m68k: apollo: Remove a duplicate assignment in dn_timer_int

Andreas Schwab
2023-07-05T12:48:07Z

On Jul 05 2023, Minjie Du wrote:

> Delete a duplicate statement from this function implementation.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> arch/m68k/apollo/config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
> index 42a8b8e2b..5645d2018 100644
> --- a/arch/m68k/apollo/config.c
> +++ b/arch/m68k/apollo/config.c
> @@ -173,7 +173,6 @@ irqreturn_t dn_timer_int(int irq, void *dev_id)
> legacy_timer_tick(1);
> timer_heartbeat();
>
> - x = *(volatile unsigned char *)(apollo_timer + 3);
> x = *(volatile unsigned char *)(apollo_timer + 5);

They are not the same: 3 != 5.

--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."