From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932100AbcFVHpw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 03:45:52 -0400
Received: from mx2.suse.de ([195.135.220.15]:56071 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752013AbcFVHpv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 03:45:51 -0400
From: Andreas Schwab <schwab@suse.de>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: Joseph Myers <joseph@codesourcery.com>, <libc-alpha@sourceware.org>,
        <linux-kernel@vger.kernel.org>, <arnd@arndb.de>,
        <catalin.marinas@arm.com>, <marcus.shawcroft@arm.com>, <philb@gnu.org>,
        <davem@davemloft.net>, <szabolcs.nagy@arm.com>,
        <maxim.kuvyrkov@linaro.org>, <pinskia@gmail.com>,
        Andrew Pinski <apinski@cavium.com>
Subject: Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.
References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com>
	<1466485631-3532-7-git-send-email-ynorov@caviumnetworks.com>
	<alpine.DEB.2.20.1606211027120.4526@digraph.polyomino.org.uk>
	<20160622060227.GA22466@yury-N73SV>
X-Yow: Well, I'm on the right planet---everyone looks like me!!!
Date: Wed, 22 Jun 2016 09:45:47 +0200
In-Reply-To: <20160622060227.GA22466@yury-N73SV> (Yury Norov's message of
	"Wed, 22 Jun 2016 09:02:27 +0300")
Message-ID: <mvm60t1psyc.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yury Norov <ynorov@caviumnetworks.com> writes:

> On Tue, Jun 21, 2016 at 10:28:40AM +0000, Joseph Myers wrote:
>> On Tue, 21 Jun 2016, Yury Norov wrote:
>> 
>> > +#ifdef __LP64__
>> > +#define RTLD_START RTLD_START_1("x", "3", "sp")
>> > +#else
>> > +#define RTLD_START RTLD_START_1("w", "2", "wsp")
>> > +#endif
>> 
>> As well as preprocessor indentation, this is missing spaces after '('; 

Before, not after.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."