From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E558C43381 for ; Mon, 25 Mar 2019 15:54:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D816420896 for ; Mon, 25 Mar 2019 15:54:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729648AbfCYPy4 (ORCPT ); Mon, 25 Mar 2019 11:54:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:38122 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729609AbfCYPy4 (ORCPT ); Mon, 25 Mar 2019 11:54:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9FB75AE0A; Mon, 25 Mar 2019 15:54:54 +0000 (UTC) From: Andreas Schwab To: Yash Shah Cc: palmer@sifive.com, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, thierry.reding@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sachin.ghadi@sifive.com, paul.walmsley@sifive.com Subject: Re: [PATCH v11 0/2] PWM support for HiFive Unleashed References: <1553508779-9685-1-git-send-email-yash.shah@sifive.com> X-Yow: Actually, what I'd like is a little toy spaceship!! Date: Mon, 25 Mar 2019 16:54:53 +0100 In-Reply-To: <1553508779-9685-1-git-send-email-yash.shah@sifive.com> (Yash Shah's message of "Mon, 25 Mar 2019 15:42:57 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mär 25 2019, Yash Shah wrote: > v11 > - Change naming convention for pwm_device and pwm_sifive_ddata pointers > - Assign of_pwm_xlate_with_flag() to of_xlate func ptr since this driver > use three pwm-cells (Issue reported by Andreas Schwab > - Other minor fixes I still don't see any improvement. FYI, this is the patch I use for the device tree: diff --git a/fsbl/ux00_fsbl.dts b/fsbl/ux00_fsbl.dts index f27cc22..56e94c0 100644 --- a/fsbl/ux00_fsbl.dts +++ b/fsbl/ux00_fsbl.dts @@ -432,7 +432,7 @@ reg-names = "control"; clocks = <&tlclk>; sifive,approx-period = <1000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; }; L46: pwm@10021000 { compatible = "sifive,pwm0"; @@ -442,46 +442,46 @@ reg-names = "control"; clocks = <&tlclk>; sifive,approx-period = <1000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; }; pwmleds { compatible = "pwm-leds"; heartbeat { - pwms = <&L45 0 0>; + pwms = <&L45 0 1000000 0>; max-brightness = <255>; linux,default-trigger = "heartbeat"; }; mtd { - pwms = <&L45 1 0>; + pwms = <&L45 1 1000000 0>; max-brightness = <255>; linux,default-trigger = "mtd"; }; netdev { - pwms = <&L45 2 0>; + pwms = <&L45 2 1000000 0>; max-brightness = <255>; linux,default-trigger = "netdev"; }; panic { - pwms = <&L45 3 0>; + pwms = <&L45 3 1000000 0>; max-brightness = <255>; linux,default-trigger = "panic"; }; /* These LEDs are on the tester board */ /* testled { - pwms = <&L46 0 0>; + pwms = <&L46 0 1000000 0>; max-brightness = <255>; }; green { - pwms = <&L46 1 0>; + pwms = <&L46 1 1000000 0>; max-brightness = <255>; }; red { - pwms = <&L46 2 0>; + pwms = <&L46 2 1000000 0>; max-brightness = <255>; }; blue { - pwms = <&L46 3 0>; + pwms = <&L46 3 1000000 0>; max-brightness = <255>; }; */ -- 2.21.0 Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."