From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752198AbcFUMNs (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 08:13:48 -0400
Received: from mx2.suse.de ([195.135.220.15]:44924 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751123AbcFUMNq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 08:13:46 -0400
From: Andreas Schwab <schwab@suse.de>
To: "Zhangjian \(Bamvor\)" <bamvor.zhangjian@huawei.com>
Cc: Yury Norov <ynorov@caviumnetworks.com>, <libc-alpha@sourceware.org>,
        <linux-kernel@vger.kernel.org>, <arnd@arndb.de>,
        <catalin.marinas@arm.com>, <marcus.shawcroft@arm.com>, <philb@gnu.org>,
        <davem@davemloft.net>, <szabolcs.nagy@arm.com>,
        <maxim.kuvyrkov@linaro.org>, <joseph@codesourcery.com>,
        <pinskia@gmail.com>, Andrew Pinski <apinski@cavium.com>,
        <gaoyongliang@huawei.com>
Subject: Re: [PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed always via 64bit values.
References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com>
	<1466485631-3532-13-git-send-email-ynorov@caviumnetworks.com>
	<mvmlh1zrn55.fsf@hawking.suse.de> <5769281D.6090109@huawei.com>
X-Yow: I think my CAREER is RUINED!!
Date: Tue, 21 Jun 2016 13:54:36 +0200
In-Reply-To: <5769281D.6090109@huawei.com> (Zhangjian's message of "Tue, 21
	Jun 2016 19:42:21 +0800")
Message-ID: <mvmfus6pxj7.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:

> Hi,
>
> On 2016/6/21 15:56, Andreas Schwab wrote:
>> Yury Norov <ynorov@caviumnetworks.com> writes:
>>
>>> diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.h b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> index 1ffabc2..42f89c8 100644
>>> --- a/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> +++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> @@ -161,11 +161,11 @@
>>>      call.  */
>>>   # undef INLINE_SYSCALL
>>>   # define INLINE_SYSCALL(name, nr, args...)				\
>>> -  ({ unsigned long _sys_result = INTERNAL_SYSCALL (name, , nr, args);	\
>>> +  ({ unsigned long long _sys_result = INTERNAL_SYSCALL (name, , nr, args);	\
>>>        if (__builtin_expect (INTERNAL_SYSCALL_ERROR_P (_sys_result, ), 0))\
>>>          {								\
>>>   	 __set_errno (INTERNAL_SYSCALL_ERRNO (_sys_result, ));		\
>>> -	 _sys_result = (unsigned long) -1;				\
>>> +	 _sys_result = (unsigned long long) -1;				\
>>>          }								\
>>>        (long) _sys_result; })
>>
>> The cast should be (long long).
> My understanding that we need more conversion, reference the follow patch:

And this:

diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.c b/sysdeps/unix/sysv/linux/aarch64/sysdep.c
index f2d5480..1bec443 100644
--- a/sysdeps/unix/sysv/linux/aarch64/sysdep.c
+++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.c
@@ -19,13 +19,13 @@
 #include <sysdep.h>
 #include <errno.h>
 
-long __syscall_error (long err);
+long long __syscall_error (long long err);
 hidden_proto (__syscall_error)
 
 /* This routine is jumped to by all the syscall handlers, to stash
    an error number into errno.  */
-long
-__syscall_error (long err)
+long long
+__syscall_error (long long err)
 {
   __set_errno (- err);
   return -1;

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."