From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32CE33B2FEA for ; Mon, 11 May 2026 07:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778486002; cv=none; b=YyO6cibTQjD+grikVl2L4s7Pnh2xpXewhu7DN9/kW6EPbqTw3sqqQpf/YDRCjKE0lRdxzVZjzIZ8m2XuVMWwd5IvQNLjWKN/NGEBS61E7SP0mKllvF+s44PIFVR/zgInsCI5SCszTJ5cjj+CEvPCVd6ivhNaW3lg8GnjWUEm73s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778486002; c=relaxed/simple; bh=KcZ+sJa136gxBVGBjfPLCNHwOK/R3f2d0Zn5rU/L19A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=pQ9KLLyFh2gBrnBfcaIVLCkVkiw7iVKAfhG1gDuHPp5ERY3DBn7A2tizdj00IxPzWIjGjb7l+/wBr80kGODJJs1BR1rCkSyY+SmIfjcj/EOxqcZ6jW66+joxKWcNxqFt846ucSmAROSQd0MPD3GhqkAZOrJ6DmSJdX1xein4tak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=v0pUWhY+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zyj0zqNH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=v0pUWhY+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zyj0zqNH; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="v0pUWhY+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zyj0zqNH"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="v0pUWhY+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zyj0zqNH" Received: from hawking.suse.de (unknown [IPv6:2a07:de40:a101:3:92b1:1cff:fe69:ddc]) by smtp-out2.suse.de (Postfix) with ESMTP id 912365BDEA; Mon, 11 May 2026 07:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778485988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CrMwjdTs3ZOqPfrtk4czGVOUuRqiGW+6XKywJYPIV94=; b=v0pUWhY+WVWI5C+299Hw8Tz/uAJwhUzDVsp0SXe1DFqqD1YZKXIvfnGFFvbonz5Yq/hC1g RggYljNRohrzC59qpnLAWRIaKUFn5m7yCFi01qMdzwqoIfSnDsn4FAEwrUZu5uE9RLnp1V 89TtYKD6kQBBlz6WqDF4EpVpWR3iEmg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778485988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CrMwjdTs3ZOqPfrtk4czGVOUuRqiGW+6XKywJYPIV94=; b=zyj0zqNHREl2W+IdqrLf3yiP78262eSIPMazok/r/cvP5U7Oih5guNiPmIKyKhiAtEkjxZ sSdPGfOO0ldwYiAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=v0pUWhY+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zyj0zqNH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778485988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CrMwjdTs3ZOqPfrtk4czGVOUuRqiGW+6XKywJYPIV94=; b=v0pUWhY+WVWI5C+299Hw8Tz/uAJwhUzDVsp0SXe1DFqqD1YZKXIvfnGFFvbonz5Yq/hC1g RggYljNRohrzC59qpnLAWRIaKUFn5m7yCFi01qMdzwqoIfSnDsn4FAEwrUZu5uE9RLnp1V 89TtYKD6kQBBlz6WqDF4EpVpWR3iEmg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778485988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CrMwjdTs3ZOqPfrtk4czGVOUuRqiGW+6XKywJYPIV94=; b=zyj0zqNHREl2W+IdqrLf3yiP78262eSIPMazok/r/cvP5U7Oih5guNiPmIKyKhiAtEkjxZ sSdPGfOO0ldwYiAg== Received: by hawking.suse.de (Postfix, from userid 17005) id 797784AADBC; Mon, 11 May 2026 09:53:08 +0200 (CEST) From: Andreas Schwab To: Zishun Yi Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, alex@ghiti.fr, ajones@ventanamicro.com, cleger@rivosinc.com, charlie@rivosinc.com, namcao@linutronix.de Subject: Re: [PATCH v2] riscv: misaligned: Restore epc in error path In-Reply-To: <20260509074053.1748061-1-vulab@iscas.ac.cn> (Zishun Yi's message of "Sat, 9 May 2026 15:40:53 +0800") References: <20260509074053.1748061-1-vulab@iscas.ac.cn> Date: Mon, 11 May 2026 09:53:08 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [15.29 / 50.00]; SPAM_FLAG(5.00)[]; NEURAL_SPAM_LONG(3.50)[1.000]; BAYES_HAM(-3.00)[100.00%]; NEURAL_SPAM_SHORT(3.00)[1.000]; HFILTER_HOSTNAME_UNKNOWN(2.50)[]; RDNS_NONE(2.00)[]; ONCE_RECEIVED(1.20)[]; HFILTER_HELO_IP_A(1.00)[hawking.suse.de]; HFILTER_HELO_NORES_A_OR_MX(0.30)[hawking.suse.de]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; MX_GOOD(-0.01)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DIRECT_TO_MX(0.00)[Gnus/5.13 (Gnus v5.13)]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; DNSWL_BLOCKED(0.00)[2a07:de40:a101:3:92b1:1cff:fe69:ddc:from]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,suse.de:mid] X-Spamd-Bar: +++++++++++++++ X-Rspamd-Queue-Id: 912365BDEA X-Spam-Score: 15.29 X-Spam-Level: *************** X-Rspamd-Action: add header X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Flag: YES X-Spam: Yes On Mai 09 2026, Zishun Yi wrote: > diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c > index 2a27d3ff4ac6..24f898853bba 100644 > --- a/arch/riscv/kernel/traps_misaligned.c > +++ b/arch/riscv/kernel/traps_misaligned.c > @@ -307,13 +307,17 @@ static int handle_scalar_misaligned_load(struct pt_regs *regs) > return -1; > } > > - if (!IS_ENABLED(CONFIG_FPU) && fp) > + if (!IS_ENABLED(CONFIG_FPU) && fp) { > + regs->epc = epc; > return -EOPNOTSUPP; > + } > > val.data_u64 = 0; > if (user_mode(regs)) { > - if (copy_from_user(&val, (u8 __user *)addr, len)) > + if (copy_from_user(&val, (u8 __user *)addr, len)) { > + regs->epc = epc; > return -1; > + } > } else { > memcpy(&val, (u8 *)addr, len); > } > @@ -409,12 +413,16 @@ static int handle_scalar_misaligned_store(struct pt_regs *regs) > return -1; > } > > - if (!IS_ENABLED(CONFIG_FPU) && fp) > + if (!IS_ENABLED(CONFIG_FPU) && fp) { > + regs->epc = epc; > return -EOPNOTSUPP; > + } > > if (user_mode(regs)) { > - if (copy_to_user((u8 __user *)addr, &val, len)) > + if (copy_to_user((u8 __user *)addr, &val, len)) { > + regs->epc = epc; > return -1; > + } I think this is better handled by a common error exit. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."