From: Andreas Schwab <schwab@linux-m68k.org>
To: Atish Patra <atish.patra@wdc.com>
Cc: linux-kernel@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Allison Randal <allison@lohutok.net>,
Anup Patel <anup@brainfault.org>,
linux-riscv@lists.infradead.org,
Palmer Dabbelt <palmer@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"hch\@infradead.org" <hch@infradead.org>
Subject: Re: [v2 PATCH] RISC-V: Optimize tlb flush path.
Date: Tue, 20 Aug 2019 09:46:20 +0200 [thread overview]
Message-ID: <mvmh86cl1o3.fsf@linux-m68k.org> (raw)
In-Reply-To: <20190820004735.18518-1-atish.patra@wdc.com> (Atish Patra's message of "Mon, 19 Aug 2019 17:47:35 -0700")
On Aug 19 2019, Atish Patra <atish.patra@wdc.com> wrote:
> @@ -42,20 +43,44 @@ static inline void flush_tlb_range(struct vm_area_struct *vma,
>
> #include <asm/sbi.h>
>
> -static inline void remote_sfence_vma(struct cpumask *cmask, unsigned long start,
> - unsigned long size)
> +static void __riscv_flush_tlb(struct cpumask *cmask, unsigned long start,
> + unsigned long size)
cmask can be const.
> {
> struct cpumask hmask;
> + unsigned int hartid;
> + unsigned int cpuid;
>
> cpumask_clear(&hmask);
> +
> + if (!cmask) {
> + riscv_cpuid_to_hartid_mask(cpu_online_mask, &hmask);
> + goto issue_sfence;
> + }
Wouldn't it make sense to fall through to doing a local flush here?
if (!cmask)
cmask = cpu_online_mask;
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2019-08-20 7:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 0:47 [v2 PATCH] RISC-V: Optimize tlb flush path Atish Patra
2019-08-20 3:06 ` hch
2019-08-20 7:14 ` Andreas Schwab
2019-08-20 7:16 ` hch
2019-08-20 7:46 ` Andreas Schwab [this message]
2019-08-20 8:42 ` Atish Patra
2019-08-20 8:51 ` Andreas Schwab
2019-08-20 9:22 ` hch
2019-08-20 20:28 ` Atish Patra
2019-08-20 22:18 ` hch
2019-08-20 22:24 ` Atish Patra
2019-08-21 1:29 ` Alan Kao
2019-08-21 1:40 ` hch
2019-08-21 3:52 ` Anup Patel
2019-08-21 7:18 ` hch
2019-08-20 8:51 ` Anup Patel
2019-08-20 20:29 ` Atish Patra
2019-08-21 14:41 ` hch
2019-08-21 14:45 ` hch
2019-08-21 17:36 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmh86cl1o3.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=allison@lohutok.net \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox