Re: [v2 PATCH] RISC-V: Optimize tlb flush path.

Andreas Schwab
2019-08-20T07:15:06Z

On Aug 19 2019, "hch@infradead.org" <hch@infradead.org> wrote:

> This looks a little odd to m and assumes we never pass a size smaller
> than PAGE_SIZE. Whule that is probably true, why not something like:
>
> if (size < PAGE_SIZE && size != -1)

ITYM size <= PAGE_SIZE. And since size is unsigned it cannot be == -1
at the same time.

> local_flush_tlb_page(start);
> else
> local_flush_tlb_all();
>
> ?

Andreas.

--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."