From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 316683A16BF for ; Mon, 30 Mar 2026 08:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774858574; cv=none; b=KH1eut2shT+utrL4yhyOTwvCjd95q0Lc4WhYCTl+s8g4bmcYHIV8fLPUp3+de9t0+4VFWrsyekoVgAf1oveQ7hfri31xGF7Xh8Q+am7EqnmFTPsP6HRyRmGZwalkuCisgqQMlx8Ju6aVkXuXuu1TTLYdiV0MNj++83t2vfEUmzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774858574; c=relaxed/simple; bh=8q9fNMC7NZbjnlxgRcb4YbT6lF4gkpAO39MoU7xPyp0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UJk/VuQzFJtRqpqM9cvpCPX45NAjNgZNQqQUJvag/3e86YGvyE8doamY1qbDqdptL4y1H84SoXGB6G61IzOV/+A8Z+lYnJKSmFH8XIXk2qFHookbCf2iXB3IZJzZoVoVzkwEqA4IGEJMtsH7ef1f8c8VVu6EiyymTT4y+RX6ahI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=dRRmbq0Y; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=UzzPY2d+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=CZrTBLhX; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YoCHFosB; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="dRRmbq0Y"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UzzPY2d+"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="CZrTBLhX"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YoCHFosB" Received: from hawking.suse.de (unknown [IPv6:2a07:de40:a101:3:92b1:1cff:fe69:ddc]) by smtp-out1.suse.de (Postfix) with ESMTP id 2B1244D521; Mon, 30 Mar 2026 08:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774858571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dbNuLtuBRyZz7R/BdCbv7TqVDsGtbVA35z28oSZF14E=; b=dRRmbq0YC319LT3TyaPsag5yT8ZSEVhRW0hXe6ZknQrqIvD1fNjGMnkN7TFER4eB08Iu4P Q6+/Mh7yFnmmOm7101o+Ym2FOS1pvGvDQEvvbsZlPjdYfWtVbhRi2WqhZ/OFpxsblk1w2a Swobio+50HXOYiJSRlRJKGAydxkr2Zo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774858571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dbNuLtuBRyZz7R/BdCbv7TqVDsGtbVA35z28oSZF14E=; b=UzzPY2d+6b5GDVjY43Ui0eH2wp9Dk3aSxB76E0HoegMEkVwNpsQunfc/jRmD1p1DWRl9vj QIoc04EqxpanbPBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CZrTBLhX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YoCHFosB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774858570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dbNuLtuBRyZz7R/BdCbv7TqVDsGtbVA35z28oSZF14E=; b=CZrTBLhXXIR0xur/o7J1cjpcb7wIqRI+RWAELp93tWHyl4l24Y1107BhmDisSmnkq4aEtv eoJ+K4ELMSR4v/3JOrYFvQk8n7ACgpaZp+pvToo+jwvX0TQIv+JzzeXW4SKCzpKHwXT2/B wZ12xIal5Wy3xJBRj9eD5wsSooG1DWA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774858570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dbNuLtuBRyZz7R/BdCbv7TqVDsGtbVA35z28oSZF14E=; b=YoCHFosBferQRNhsCEhAkOJgSzRbYsxmkUAIrZEpXW1BWOxNbmAyMKNI0mYDzTNK/GUfaK b4izdpnWrlZ8bYBg== Received: by hawking.suse.de (Postfix, from userid 17005) id E2A9D4A04D9; Mon, 30 Mar 2026 10:16:09 +0200 (CEST) From: Andreas Schwab To: Michael Neuling Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, debug@rivosinc.com, thecharlesjenkins@gmail.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: ptrace: avoid BIT() in UAPI header In-Reply-To: <20260330024248.449292-1-mikey@neuling.org> (Michael Neuling's message of "Mon, 30 Mar 2026 02:42:48 +0000") References: <20260330024248.449292-1-mikey@neuling.org> Date: Mon, 30 Mar 2026 10:16:09 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [15.27 / 50.00]; SPAM_FLAG(5.00)[]; NEURAL_SPAM_LONG(3.48)[0.993]; BAYES_HAM(-3.00)[99.99%]; NEURAL_SPAM_SHORT(3.00)[1.000]; HFILTER_HOSTNAME_UNKNOWN(2.50)[]; RDNS_NONE(2.00)[]; ONCE_RECEIVED(1.20)[]; HFILTER_HELO_IP_A(1.00)[hawking.suse.de]; HFILTER_HELO_NORES_A_OR_MX(0.30)[hawking.suse.de]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; DIRECT_TO_MX(0.00)[Gnus/5.13 (Gnus v5.13)]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; SPAMHAUS_XBL(0.00)[2a07:de40:a101:3:92b1:1cff:fe69:ddc:from]; DNSWL_BLOCKED(0.00)[2a07:de40:a101:3:92b1:1cff:fe69:ddc:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; RCPT_COUNT_SEVEN(0.00)[9]; FREEMAIL_CC(0.00)[kernel.org,dabbelt.com,eecs.berkeley.edu,ghiti.fr,rivosinc.com,gmail.com,lists.infradead.org,vger.kernel.org]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[hawking.suse.de:helo,suse.de:dkim,suse.de:mid,suse.de:email] X-Spamd-Bar: +++++++++++++++ X-Rspamd-Queue-Id: 2B1244D521 X-Rspamd-Action: add header X-Spam-Flag: YES X-Spam-Score: 15.27 X-Spam-Level: *************** X-Spam: Yes On Mär 30 2026, Michael Neuling wrote: > BIT() is not available in UAPI headers — the installed linux/bits.h > (UAPI version) does not define it. Replace BIT() with open-coded > (1UL << x) which is the standard practice for UAPI headers, and drop > the linux/bits.h include that was added by commit 98545620b0 ("riscv: > ptrace: Fix BIT() compilation issues"). There is also the _BITUL macro, which may be preferable. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."