From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91939C43441 for ; Wed, 10 Oct 2018 13:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 592812087A for ; Wed, 10 Oct 2018 13:28:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 592812087A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbeJJUvE (ORCPT ); Wed, 10 Oct 2018 16:51:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:50426 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726503AbeJJUvE (ORCPT ); Wed, 10 Oct 2018 16:51:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D12ACB0BC; Wed, 10 Oct 2018 13:28:51 +0000 (UTC) From: Andreas Schwab To: Christoph Hellwig Cc: Atish Patra , palmer@sifive.com, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, robh+dt@kernel.org, thierry.reding@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com Subject: Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs References: <1539111085-25502-1-git-send-email-atish.patra@wdc.com> <1539111085-25502-5-git-send-email-atish.patra@wdc.com> <20181010131255.GB29142@infradead.org> X-Yow: .. So, if we convert SUPPLY-SIDE SOYBEAN FUTURES into HIGH-YIELD T-BILL INDICATORS, the PRE-INFLATIONARY risks will DWINDLE to a rate of 2 SHOPPING SPREES per EGGPLANT!! Date: Wed, 10 Oct 2018 15:28:50 +0200 In-Reply-To: <20181010131255.GB29142@infradead.org> (Christoph Hellwig's message of "Wed, 10 Oct 2018 06:12:55 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Okt 10 2018, Christoph Hellwig wrote: > On Wed, Oct 10, 2018 at 03:01:29PM +0200, Andreas Schwab wrote: >> On Okt 09 2018, Atish Patra wrote: >> >> > +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset) >> > +{ >> > + unsigned long flags; >> > + unsigned int trigger; >> > + >> > + raw_spin_lock_irqsave(&chip->lock, flags); >> > + trigger = (chip->enabled & BIT(offset)) ? chip->trigger[offset] : 0; >> >> This should use test_bit instead. > > Given that this apparently needs the spinlock for atomciy with more than > just the bitmap test_bit would be rather pointless. BIT and test_bit/assign_bit are not compatible. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."