From: Andreas Schwab <schwab@suse.de>
To: David Abdurachmanov <david.abdurachmanov@gmail.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
David Abdurachmanov <david.abdurachmanov@sifive.com>,
Kees Cook <keescook@chromium.org>,
Anup Patel <Anup.Patel@wdc.com>,
Vincent Chen <vincent.chen@sifive.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Bin Meng <bmeng.cn@gmail.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: reject invalid syscalls below -1
Date: Wed, 18 Dec 2019 10:46:06 +0100 [thread overview]
Message-ID: <mvmo8w63r1d.fsf@suse.de> (raw)
In-Reply-To: <20191218084757.904971-1-david.abdurachmanov@sifive.com> (David Abdurachmanov's message of "Wed, 18 Dec 2019 10:47:56 +0200")
On Dez 18 2019, David Abdurachmanov wrote:
> diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S
> index a1349ca64669..e163b7b64c86 100644
> --- a/arch/riscv/kernel/entry.S
> +++ b/arch/riscv/kernel/entry.S
> @@ -246,6 +246,7 @@ check_syscall_nr:
> */
> li t1, -1
> beq a7, t1, ret_from_syscall_rejected
> + blt a7, t1, 1f
How about using bgeu instead in the preceding check?
/*
* Syscall number held in a7.
* If syscall number is above allowed value, redirect to ni_syscall.
*/
bge a7, t0, 1f
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2019-12-18 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 8:47 [PATCH] riscv: reject invalid syscalls below -1 David Abdurachmanov
2019-12-18 9:46 ` Andreas Schwab [this message]
2019-12-18 10:06 ` David Abdurachmanov
2019-12-18 10:35 ` Andreas Schwab
2019-12-28 6:02 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmo8w63r1d.fsf@suse.de \
--to=schwab@suse.de \
--cc=Anup.Patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=bmeng.cn@gmail.com \
--cc=david.abdurachmanov@gmail.com \
--cc=david.abdurachmanov@sifive.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=vincent.chen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox