Re: [PATCH RESEND 0/2] RISC-V: Handle the siginfo_t offset problem

Andreas Schwab
2019-07-04T07:20:30Z

On Jul 03 2019, Alistair Francis <alistair23@gmail.com> wrote:

> On Wed, Jul 3, 2019 at 12:08 AM Andreas Schwab <schwab@suse.de> wrote:
>>
>> On Jul 02 2019, Alistair Francis <alistair.francis@wdc.com> wrote:
>>
>> > In the RISC-V 32-bit glibc port [1] the siginfo_t struct in the kernel
>> > doesn't line up with the struct in glibc. In glibc world the _sifields
>> > union is 8 byte alligned (although I can't figure out why)
>>
>> Try ptype/o in gdb.
>
> That's a useful tip, I'll be sure to use that next time.

It was a serious note. If the structs don't line up then there is a
mismatch in types that cannot be solved by adding spurious padding. You
need to fix the types instead.

Andreas.

--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."