From: Andreas Schwab <schwab@linux-m68k.org>
To: Finn Thain <fthain@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nubus: Don't list card resources by default
Date: Thu, 23 Mar 2023 09:39:31 +0100 [thread overview]
Message-ID: <mvmttybx3ng.fsf@linux-m68k.org> (raw)
In-Reply-To: <5b7c473247d66776343d82a55b9815195b1b11fb.1679551394.git.fthain@linux-m68k.org> (Finn Thain's message of "Thu, 23 Mar 2023 17:03:14 +1100")
On Mär 23 2023, Finn Thain wrote:
> Checkpatch says "externs should be avoided in .c files" and if this one
> appeared twice I would agree. But as it only appears once, I can't see
> any advantage to putting it in a new .h file instead of the .c file...
Anything wrong with declaring it in <linux/nubus.h>?
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2023-03-23 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 6:03 [PATCH v2] nubus: Don't list card resources by default Finn Thain
2023-03-23 8:19 ` Geert Uytterhoeven
2023-03-23 23:13 ` Finn Thain
2023-03-24 8:59 ` Brad Boyer
2023-03-24 23:35 ` Finn Thain
2023-03-25 12:44 ` Geert Uytterhoeven
2023-03-26 0:03 ` Brad Boyer
2023-03-26 8:23 ` Geert Uytterhoeven
2023-03-26 0:00 ` Brad Boyer
2023-03-26 3:22 ` Finn Thain
2023-03-23 8:39 ` Andreas Schwab [this message]
2023-03-23 8:41 ` Geert Uytterhoeven
2023-03-24 0:08 ` Finn Thain
2023-03-24 8:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmttybx3ng.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox