From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752393AbcF1QFu (ORCPT ); Tue, 28 Jun 2016 12:05:50 -0400 Received: from plane.gmane.org ([80.91.229.3]:45059 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbcF1QFt (ORCPT ); Tue, 28 Jun 2016 12:05:49 -0400 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: Grant Edwards Subject: Re: RFC: out-of-tree tty driver breakage (changing ASYNC_ bits) Date: Tue, 28 Jun 2016 16:05:33 +0000 (UTC) Message-ID: References: <5692D054.7050203@hurleysoftware.com> <20160111044204.GB12741@kroah.com> <5693D72D.6050501@hurleysoftware.com> X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 67-130-15-94.dia.static.qwest.net User-Agent: slrn/1.0.2 (Linux) Cc: linux-serial@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-06-28, Grant Edwards wrote: > On 2016-06-28, Grant Edwards wrote: >> On 2016-01-11, Peter Hurley wrote: >>> On 01/11/2016 07:53 AM, Grant Edwards wrote: >>>> On 2016-01-11, Greg KH wrote: >>>>> On Sun, Jan 10, 2016 at 01:42:44PM -0800, Peter Hurley wrote: >>>>> >>>>>> This will break out-of-tree drivers but I don't really see a >>>>>> realistic alternative. Also, I think the new symbol prefix ASY_ isn't >>>>>> great and I'd like to get some suggestions. >>>>> >>>>> Don't worry about breaking out-of-tree drivers, that's fine. >>>> >>>> One request from this maintainer of several out-of-tree drivers: if >>>> you break something, break it such that it won't compile. It would be >>>> nice to avoid changes that break functionality but still compile >>>> without warning. >>> >>> I was in the process of writing how I can't remove >>> ASYNC_INITIALIZED, et.al from the uapi header, when I realized that >>> I can just guard them with #ifndef _KERNEL_ which will trigger the >>> requisite out-of-tree build break. > >> You know that _KERNEL_ is defined when when compiling kernel-space >> code (either in-tree or out-of-tree), right? > > Ignore that. I missed the 'n' in #ifndef. My driver build should > fail due to ASYNC_INITIALIZED being undefined, but it isn't. :/ > > For some reason _KERNEL_ is not defined when my module is being > compiled.... That's because it's __KERNEL__ not _KERNEL_ that get's defined when compiling kernel-space code. So, in tty_flags.h: 81 #define ASYNC_SPD_MASK (ASYNC_SPD_HI|ASYNC_SPD_VHI|ASYNC_SPD_SHI) 82 83 #ifndef _KERNEL_ 84 /* These flags are no longer used (and were always masked from userspace) */ 85 #define ASYNC_INITIALIZED (1U << ASYNCB_INITIALIZED) 86 #define ASYNC_NORMAL_ACTIVE (1U << ASYNCB_NORMAL_ACTIVE) Shoulnd't line 83 be #ifndef __KERNEL__ ? -- Grant Edwards grant.b.edwards Yow! PARDON me, am I at speaking ENGLISH? gmail.com