From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751226AbdJDGg6 (ORCPT ); Wed, 4 Oct 2017 02:36:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbdJDGgy (ORCPT ); Wed, 4 Oct 2017 02:36:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 163E87EAA1 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=ppandit@redhat.com Date: Wed, 4 Oct 2017 12:06:42 +0530 (IST) From: P J P X-X-Sender: pjp@javelin To: Brijesh Singh cc: bp@suse.de, Paolo Bonzini , =?ISO-8859-2?Q?Radim_Kr=E8m=E1=F8?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 Patch v4.2] crypto: ccp: Add Platform Security Processor (PSP) device support In-Reply-To: <20171002164344.12750-1-brijesh.singh@amd.com> Message-ID: References: <20170919204627.3875-6-brijesh.singh@amd.com> <20171002164344.12750-1-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 04 Oct 2017 06:36:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +-- On Mon, 2 Oct 2017, Brijesh Singh wrote --+ | +int psp_dev_init(struct sp_device *sp) | +{ | + struct device *dev = sp->dev; | + struct psp_device *psp; | + int ret; | + | + ret = -ENOMEM; | + psp = psp_alloc_struct(sp); | + if (!psp) | + goto e_err; | + | + sp->psp_data = psp; | ... | +e_err: | + sp->psp_data = NULL; Needs to kfree(sp->psp_data) before setting to NULL. -- - P J P 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F