From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751337AbdAVH6e (ORCPT <rfc822;w@1wt.eu>);
        Sun, 22 Jan 2017 02:58:34 -0500
Received: from [195.159.176.226] ([195.159.176.226]:56773 "EHLO
        blaine.gmane.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org
        with ESMTP id S1750925AbdAVH60 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 22 Jan 2017 02:58:26 -0500
X-Injected-Via-Gmane: http://gmane.org/
To: linux-kernel@vger.kernel.org
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH 3/5] s390/pci: Move three assignments for the variable
 "rc" in clp_normal_command()
Date: Sun, 22 Jan 2017 08:58:07 +0100
Message-ID: <o61omd$vb4$1@blaine.gmane.org>
References: <f2233afd-bc54-0697-0709-9577e96fc6a6@users.sourceforge.net>
 <d8178ea8-8a46-b922-c486-d741dd916565@users.sourceforge.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Complaints-To: usenet@blaine.gmane.org
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
In-Reply-To: <d8178ea8-8a46-b922-c486-d741dd916565@users.sourceforge.net>
X-Antivirus: avast! (VPS 170121-0, 21/01/2017), Outbound message
X-Antivirus-Status: Clean
Cc: kernel-janitors@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Le 21/01/2017 à 19:12, SF Markus Elfring a écrit :
> @@ -541,9 +543,8 @@ static int clp_normal_command(struct clp_req *req)
>   	if (rc)
>   		goto out_free;
>   
> -	rc = -EFAULT;
>   	if (copy_to_user(uptr, lpcb, PAGE_SIZE) != 0)
> -		goto out_free;
> +		rc = -EFAULT;
>   
>   	rc = 0;
>   

With this, we return 0 (success) on error.

CJ