From: "Andreas Block" <andreas.block@esd-electronics.com>
To: "Xavier Bestel" <xavier.bestel@free.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Bugfixes: PCI devices get assigned redundant IRQs
Date: Fri, 26 Jan 2007 13:54:43 +0100 [thread overview]
Message-ID: <op.tmrh5hxp8n9ctc@pc-block.esd> (raw)
In-Reply-To: <1169809255.10952.178.camel@frg-rhel40-em64t-03>
On Fri, 26 Jan 2007 12:00:55 +0100, Xavier Bestel <xavier.bestel@free.fr>
wrote:
> On Fri, 2007-01-26 at 11:50 +0100, Andreas Block wrote:
>
>> u8 pin, slot;
>> - int irq;
>> + int irq = 0;
>
> Aren't there platforms for which irq = 0 is a valid irq ?
As far as I understand the PCI spec, the answer to your question seems to
be: no
(or I'm missing something).
Don't get me wrong. I'm not talking about system IRQs, but about the value
of the Interrupt Pin Register in PCI configuration space.
The PCI Local Bus Specification in Revision 3.0 from 3rd February 2004
says on page 223 about the content of Interrupt Pin register:
Value 0x00: _No_ interrupt
Values 0x01 to 0x04: Interrupt lines A to D
And values 5 to 0xFF are reserved.
So I'd say, the "correction" of greater values than four to a value of one
seems discussable, too. Because it will break any future changes of the
PCI spec.
Andreas
--
-------------------------------------------------------------------------
_/_/_/_/ Andreas Block
_/_/_/_/ Dipl.-Ing.
_/_/_/_/ andreas.block@esd-electronics.com
_/_/_/ _/_/_/_/_/_/_/ esd electronic system design gmbh
_/ _/ _/ _/ Vahrenwalder Str. 207
_/ _/ _/_/_/ _/ _/ D-30165 Hannover
_/ _/ _/ _/ Phone: +49-511-37298-0
_/_/_/_/_/_/_/ _/_/_/ Fax: +49-511-37298-68
http://www.esd-electronics.com
-------------------------------------------------------------------------
next prev parent reply other threads:[~2007-01-26 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 10:50 Bugfixes: PCI devices get assigned redundant IRQs Andreas Block
2007-01-26 11:00 ` Xavier Bestel
2007-01-26 12:54 ` Andreas Block [this message]
2007-01-28 8:04 ` H. Peter Anvin
2007-01-28 15:35 ` Andreas Block
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.tmrh5hxp8n9ctc@pc-block.esd \
--to=andreas.block@esd-electronics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xavier.bestel@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox