From: "Michal Nazarewicz" <mina86@mina86.com>
To: "Felipe Balbi" <balbi@ti.com>, Tonylijo <mail@tonylijo.in>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] usb : gadget : usbstring : fix style problems
Date: Thu, 17 Nov 2011 13:44:47 +0100 [thread overview]
Message-ID: <op.v43ccxbe3l0zgt@mpn-glaptop> (raw)
In-Reply-To: <1321527544.2367.29.camel@debian1.ic>
On Thu, 17 Nov 2011 11:59:04 +0100, Tonylijo <mail@tonylijo.in> wrote:
> @@ -84,8 +90,8 @@ fail:
> }
>-/**
> - * usb_gadget_get_string - fill out a string descriptor
> +/*
> + * usb_gadget_get_string - fill out a string descriptor
Shouldn't that be usb_gadget_get_string() (ie. with parens)?
> * @table: of c strings encoded using UTF-8
> * @id: string id, from low byte of wValue in get string descriptor
> * @buf: at least 256 bytes
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
next prev parent reply other threads:[~2011-11-17 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 10:59 [PATCH][RESEND] usb : gadget : usbstring : fix style problems Tonylijo
2011-11-17 12:20 ` Sergei Shtylyov
2011-11-17 13:03 ` tonylijo
2011-11-17 12:44 ` Michal Nazarewicz [this message]
2011-11-17 12:51 ` Sergei Shtylyov
2011-11-17 13:12 ` tonylijo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v43ccxbe3l0zgt@mpn-glaptop \
--to=mina86@mina86.com \
--cc=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@tonylijo.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox