Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

Alan Stern
2010-07-19T18:37:41Z

On Mon, 19 Jul 2010, [utf-8] MichaÅ‚ Nazarewicz wrote:

> On Mon, 19 Jul 2010 19:06:32 +0200, Alan Stern <stern@rowland.harvard.edu> wrote:
> >> 1/3: http://lkml.org/lkml/2010/7/8/317
>
> > Ah, yes. My personal taste would be to write fsg_string_serial_fill_n
> > as an inline routine instead of as a macro, and not try to make it
> > separate from fsg_string_serial_fill.
>
> >> 2/3: http://lkml.org/lkml/2010/7/8/318
>
> > I have only one objection to this patch: The new parameter's name
> > should be "serial", not "serial_parm". (Compare it to all the other
> > parameter names.)
>
> Will change the two tomorrow.

Come to think of it, there was one other issue. The serial number
parameter is important enough that it should be available even on
builds without CONFIG_USB_FILE_STORAGE_TEST (because for general use,
we must make it possible to set the serial number to a unique value for
every instance of the gadget). Moving the code around should be fairly
easy.

Alan Stern