Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

Alan Stern
2010-07-20T14:07:37Z

On Tue, 20 Jul 2010, [utf-8] MichaÅ‚ Nazarewicz wrote:

> On Mon, 19 Jul 2010 19:41:10 +0200, David Brownell <david-b@pacbell.net> wrote:
> >> I'm not entirely sure of what the issue with
> >> the patches is really. It merely adds a serial
> >> number to the gadgets using MSF and that's all.
> >
> > Go back and read what I wrote then. The issue is
> > that THERE ALREADY IS SUCH A MECHANISM. We neither
> > need or want another way to do it. The answer is to
> > use the existing mechanism correctly.
>
> There is no existing mechanism. If the module does not set the
> iSerialNumber field the iSerialNumber module parameter won't work
> and I don't see any other way to set the string. If there is one,
> please show it to me.

That's clearly a bug. Change the code so that a module parameter will
always work, even if a function driver doesn't specify a serial number
string.

Alan Stern