Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

Michał Nazarewicz
2010-07-20T08:40:29Z

On Mon, 19 Jul 2010 19:41:10 +0200, David Brownell <david-b@pacbell.net> wrote:
>> I'm not entirely sure of what the issue with
>> the patches is really. It merely adds a serial
>> number to the gadgets using MSF and that's all.
>
> Go back and read what I wrote then. The issue is
> that THERE ALREADY IS SUCH A MECHANISM. We neither
> need or want another way to do it. The answer is to
> use the existing mechanism correctly.

There is no existing mechanism. If the module does not set the
iSerialNumber field the iSerialNumber module parameter won't work
and I don't see any other way to set the string. If there is one,
please show it to me.

> Plus, you seem to be overlooking the basic need
> (for userspace) to manage these IDs so they're
> properly unique. Two gadgets should never end up
> using the same serial number.

I'm not overlooking that. I simply consider that a separate issue.
Driver should provide some kind of default (just like File Storage
Gadget) and the fact that user space should override it is another
matter in my opinion.

This is especially true, since the iSerialNumber module parameter
won't work without iSerialNumber set (which I pointed several
times).

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--