Re: [PATCHv4 1/5] USB: gadget: composite: Better string override handling

Greg KH
2010-07-22T23:55:17Z

On Thu, Jul 22, 2010 at 02:16:33PM +0200, Michal Nazarewicz wrote:
> The iManufatcurer, iProduct and iSerialNumber composite module
> parameters are only used when the gadget driver registers
> strings for manufacturer, product and serial number. If the
> gadget never bothered to set corresponding fields in USB
> device descriptors those module parameters are ignored.
>
> This patch makes the parameters even if the strings ID have
> not been assigned. It also changes the way IDs are
> overridden -- what IDs are overridden is now saved in
> usb_composite_dev structure -- which makes it unnecessary to
> modify the string tables the way previous code did.

David, do these look better?

And they are not -stable material, no matter what, sorry, so you can
stop copying stable@kernel.org on them.

thanks,

greg k-h