Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

Alan Stern
2010-07-20T14:08:55Z

On Tue, 20 Jul 2010, [utf-8] MichaÅ‚ Nazarewicz wrote:

> > On Mon, 19 Jul 2010, [utf-8] Michal‚ Nazarewicz wrote:
> >> 1/3: http://lkml.org/lkml/2010/7/8/317
> >> Adds serial to mass storage gadget and g_multi introducing
> >> fsg_string_serial_fill() macro used by abovementioned
> >> gadgets and file storage gadget.
>
> On Mon, 19 Jul 2010 19:06:32 +0200, Alan Stern <stern@rowland.harvard.edu> wrote:
> > Ah, yes. My personal taste would be to write fsg_string_serial_fill_n
> > as an inline routine instead of as a macro, and not try to make it
> > separate from fsg_string_serial_fill.
>
> Not sure what you meant by "make it separate from fsg_string_serial_fill".

I mean have a single function, called "fsg_string_serial_fill", instead
of two separate macros called "fsg_string_serial_fill" and
"fsg_string_serial_fill_n".

Alan Stern