Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

Michał Nazarewicz
2010-07-19T12:06:15Z

On Mon, 19 Jul 2010 12:08:36 +0200, David Brownell <david-b@pacbell.net> wrote:
>> It in no way duplicates functionality of the composite layer.

> Beyond the obvious "Set serial number" ...

In that case, should all the composite gadgets stop setting
the iManufacturer, iProduct and iSerialNumber? My understanding
is that the composite module parameters are only meant as a way
to override what the module uses as default. Using your
rationale, modules should not only stop setting those fields but
also the idVendor and idProduct.

>> As a matter of fact, without this patch, the
>> iSerialNumber module parameter won't work

> So submit a bugfix for that alone, making it
> work everywhere...

iSerialNumber not working is not the main issue. The main issue
is that the serial number is not set by default which makes
Windows sad (Windows uses serial number to distinguish different
devices with the same vendor and product ID). The serial number
has to be set by default without the need for user to give a
module parameter.

So even if composite.c were to be modified the code in mass
storage gadget would have to stay anyway.

> Do you know when it broke? That code has been
> tested in the past, and observed to work. So if
> it's not working now, someone broke it and that
> should just be fixed.

It never broke. It was "broken" from the beginning. Here's part of
composite.c that handles the iSerialNumber:

if (cdev->desc.iSerialNumber && iSerialNumber)
string_override(composite->strings,
cdev->desc.iSerialNumber, iSerialNumber);

As you see, the iSerialNumber module parameter is ignored unless the
gadget driver sets the iSerialNumber field of the device descriptor.
This patch makes mass storage gadget and g_multi set it. As said
above, this is orthogonal to changing the behaviour of the
iSerialNumber module parameter.

>> The second patch (by Yann Cantin) adds a serial module
>> parameter to
>> the File Storage Gadget. FSG is not a composite
>> gadget

> OK, so it should add a module param with the same
> name as used elsewhere ...

I was going to propose that but file storage gadget uses names
different from composite anyway (ie. vendor and product instead of
idVendor and idProduct) so I dunno if it's worth it. As a matter
of fact, "serial" seems to match the other names better.

> makes sense to me. I Alan Acks that patch, go for it.

I believe Alan already agreed on this patch. I'm merely updating
it to use the changes introduced by my patch to mass storage and
g_multi.

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--