Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number

Michał Nazarewicz
2010-07-08T20:01:46Z

>> >> This commit adds iSerialNumber to all gadgets that
>> use the Mass Storage Function.

On Thu, 08 Jul 2010 21:31:23 +0200, David Brownell <david-b@pacbell.net> wrote:
> Can it be made to do so only when the gadget
> hasn't been provided with one already? Serial
> number module options are standard parts of the
> composite gadget framework...

I don't see a way for the gadget to know whether user gave the iSerialNumber
parameter (other then reading the iSerialNumber variable but I consider that
ugly).

Plus, in any event, gadget has to reserve a string ID for serial number
anyway. Otherwise composite won't override the string.

PS. I've just spotted a bug in Yann's patch (string is not filled if
CONFIG_USB_FILE_STORAGE_TEST is undefined). It's a trivial issue so
I'll fix it with updated version.

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--