Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

Alan Stern
2010-07-19T17:06:34Z

On Mon, 19 Jul 2010, [utf-8] MichaÅ‚ Nazarewicz wrote:

> >>> I have lost track of the current state of that patch. When you finish
> >>> updating it, please post it for my review.
>
> > On Mon, 19 Jul 2010, Michal‚ Nazarewicz wrote:
> >> This is still the v3 patchset (only the first two should be of
> >> interest to you), still want me to resend?
>
> On Mon, 19 Jul 2010 18:14:01 +0200, Alan Stern wrote:
> > Or provide a URL for them in the mailing list archives.
>
> 1/3: http://lkml.org/lkml/2010/7/8/317
> Adds serial to mass storage gadget and g_multi introducing
> fsg_string_serial_fill() macro used by abovementioned
> gadgets and file storage gadget.

Ah, yes. My personal taste would be to write fsg_string_serial_fill_n
as an inline routine instead of as a macro, and not try to make it
separate from fsg_string_serial_fill.

> 2/3: http://lkml.org/lkml/2010/7/8/318
> Modification of Yann Cantin's patch, delta in comment for 1/3.

I have only one objection to this patch: The new parameter's name
should be "serial", not "serial_parm". (Compare it to all the other
parameter names.)

> 3/3: http://lkml.org/lkml/2010/7/8/316
> Modification of patch for earlier patch for g_multi. Dunno if
> you want to look at it. Providing URL for completeness.

No comment on that one.

As for the discussion between you and David... I haven't tried to
follow the details very carefully. I get the impression that the two
of you are talking past each other instead of coming to grips with a
genuine issue.

Alan Stern