Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number

David Brownell
2010-07-08T20:20:15Z

> > Can it be made to do so only when the gadget
> > hasn't been provided with one already?  Serial
> > number module options are standard parts of the
> > composite gadget framework...
>
> I don't see a way for the gadget to know whether user gave
> the iSerialNumber
> parameter (other then reading the iSerialNumber variable
> but I consider that ugly).

Uglier still is the current patch overriding
that explicitly-given parameter.

NAK until this issue is resolved.