Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

Michał Nazarewicz
2010-07-19T08:57:00Z

On Sun, 18 Jul 2010 01:57:30 +0200, David Brownell <david-b@pacbell.net> wrote:
> Still no fan, since it just duplicates
> existing functionality from the composite
> framework. Using the existing mechanism
> seems preferable to me: you want a serial
> number? provide one using the existing scheme
> and just make sure it follows the rules.

Hello David,

I'm still not sure what you mean.

As a matter of fact I think you might be confusing Mass Storage Gadget
with File Storage Gadget.

The first patch in the series merely adds the initialisation for the
iSerialNumber field of the descriptor of Mass Storage Gadget (which
is a composite gadget). It in no way duplicates functionality of
the composite layer. As a matter of fact, without this patch, the
iSerialNumber module parameter won't work (not tested, just looked
at the code).

The second patch (by Yann Cantin) adds a serial module parameter to
the File Storage Gadget. FSG is not a composite gadget so the patch
does not duplicate composite functionality (well it does but it's
irrelevant since FSG cannot use composite anyway).

The third patch is irrelevant in this discussion I believe.

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--