Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

Alan Stern
2010-07-19T14:19:10Z

On Mon, 19 Jul 2010, [utf-8] MichaÅ‚ Nazarewicz wrote:

> >> The second patch (by Yann Cantin) adds a serial module
> >> parameter to
> >> the File Storage Gadget. FSG is not a composite
> >> gadget
>
> > OK, so it should add a module param with the same
> > name as used elsewhere ...
>
> I was going to propose that but file storage gadget uses names
> different from composite anyway (ie. vendor and product instead of
> idVendor and idProduct) so I dunno if it's worth it. As a matter
> of fact, "serial" seems to match the other names better.
>
> > makes sense to me. I Alan Acks that patch, go for it.
>
> I believe Alan already agreed on this patch. I'm merely updating
> it to use the changes introduced by my patch to mass storage and
> g_multi.

I have lost track of the current state of that patch. When you finish
updating it, please post it for my review.

Alan Stern