public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Greg KH" <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 2/2 v2] usb gadget: don't save bind callback in struct usb_configuration
Date: Fri, 06 Aug 2010 10:46:50 +0200	[thread overview]
Message-ID: <op.vg0dccfk7p4s8u@pikus> (raw)
In-Reply-To: <20100805223435.GC18619@kroah.com>

On Fri, 06 Aug 2010 00:34:35 +0200, Greg KH <greg@kroah.com> wrote:

> On Thu, Aug 05, 2010 at 11:50:17AM +0200, Uwe Kleine-König wrote:
>> The bind function is most of the time only called at init time so there is no
>> need to save a pointer to it in the configuration structure.
>>
>> This fixes many section mismatches reported by modpost.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Cc: Michał Nazarewicz <m.nazarewicz@samsung.com>
>> Cc: Greg Kroah-Hartman <gregkh@suse.de>
>> ---
>> changes since v1:
>
> I'm confused, can you resend what you want me to apply please?
>
> Do I need to drop Michał's patch before applying yours?

Yep.  Uwe's patches seem to be a better solution for fixing the section
mismatch.  They remove the need of __ref* tags.  I looked through them
and they seem fine to me.

(Also, as I realised a minute ago, my patch is incorrect.)

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--

  parent reply	other threads:[~2010-08-06  8:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <op.vgs04dub7p4s8u@pikus>
     [not found] ` <1280752803-11441-1-git-send-email-u.kleine-koenig@pengutronix.de>
2010-08-02 12:45   ` [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver Christoph Hellwig
     [not found]   ` <op.vgtecwcq7p4s8u@pikus>
2010-08-02 18:25     ` Uwe Kleine-König
2010-08-02 18:27       ` [PATCH 1/2] " Uwe Kleine-König
2010-08-05  8:58         ` Michał Nazarewicz
2010-08-05  9:39           ` Uwe Kleine-König
2010-08-05 10:37             ` Michał Nazarewicz
2010-08-02 18:27       ` [PATCH 2/2] usb gadget: don't save bind callback in struct usb_configuration Uwe Kleine-König
2010-08-05  9:05         ` Michał Nazarewicz
2010-08-05  9:45           ` Uwe Kleine-König
2010-08-05 10:02             ` Michał Nazarewicz
2010-08-05  9:50           ` [PATCH 2/2 v2] " Uwe Kleine-König
2010-08-05 22:34             ` Greg KH
2010-08-06  4:50               ` Uwe Kleine-König
2010-08-06  8:46               ` Michał Nazarewicz [this message]
     [not found]   ` <Pine.LNX.4.64.1008021446470.10662@ask.diku.dk>
     [not found]     ` <20100802131248.GD13900@pengutronix.de>
     [not found]       ` <20100802225440.GA9190@suse.de>
2010-08-03  7:40         ` [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.vg0dccfk7p4s8u@pikus \
    --to=m.nazarewicz@samsung.com \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox